Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Change processor config tests to unmarshal config only for that component. (part 1) #13298

Merged
merged 3 commits into from
Aug 15, 2022
Merged

[chore] Change processor config tests to unmarshal config only for that component. (part 1) #13298

merged 3 commits into from
Aug 15, 2022

Conversation

kovrus
Copy link
Member

@kovrus kovrus commented Aug 12, 2022 •
edited
Loading

Description:

Change processor config tests to unmarshal config for that component.

  • attributesprocessor
  • cumulativetodeltaprocessor
  • deltatorateprocessor
  • filterprocessor
  • groupbyattrsprocessor
  • groupbytraceprocessor

Link to tracking Issue:

Updates #13224

@kovrus kovrus force-pushed the issue-13224/processors branch from c7f6a42 to e13b1ff Compare August 15, 2022 10:31
@kovrus kovrus changed the title [chore] change processor config tests to unmarshal the config for that component [chore] Change processor config tests to unmarshal config only for that component Aug 15, 2022
@kovrus kovrus changed the title [chore] Change processor config tests to unmarshal config only for that component [chore] Change processor config tests to unmarshal config only for that component. (part 1) Aug 15, 2022
@kovrus kovrus marked this pull request as ready for review August 15, 2022 10:44
@kovrus kovrus requested a review from a team August 15, 2022 10:44
@kovrus
Copy link
Member Author

kovrus commented Aug 15, 2022 •
edited
Loading

Some checks fail coz of #11116

bogdandrutu
bogdandrutu reviewed Aug 15, 2022
View reviewed changes
processor/cumulativetodeltaprocessor/factory_test.go Outdated Show resolved Hide resolved
processor/cumulativetodeltaprocessor/config_test.go Outdated Show resolved Hide resolved
processor/deltatorateprocessor/config_test.go Show resolved Hide resolved
processor/deltatorateprocessor/factory_test.go Outdated Show resolved Hide resolved
processor/filterprocessor/factory_test.go Outdated Show resolved Hide resolved
@kovrus kovrus requested a review from bogdandrutu August 15, 2022 20:00
kovrus added 3 commits August 15, 2022 22:24
@kovrus
[chore] change processor config tests to unmarshal config only for th…
373a57e 
…at component.

Updates open-telemetry#13224

- attributesprocessor
- cumulativetodeltaprocessor
- deltatorateprocessor
- filterprocessor
- groupbyattrsprocessor
- groupbytraceprocessor
@kovrus
[chore] Address comments.
a05b8d9
@kovrus
[chore] run "make gotidy"
5928bb7 
build-and-test / checks (pull_request) Failing after 3m — checks

Following instructions:
```
go.mod/go.sum deps changes detected, please run "make gotidy" and commit the changes in this PR.
```
@kovrus kovrus force-pushed the issue-13224/processors branch from 406de05 to 5928bb7 Compare August 15, 2022 20:29
@bogdandrutu bogdandrutu merged commit 038c562 into open-telemetry:main Aug 15, 2022
@kovrus kovrus mentioned this pull request Aug 24, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

Assignees

@Aneurysm9 Aneurysm9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kovrus @bogdandrutu @Aneurysm9