Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/loadbalancing] Flaky Test - TestRollingUpdatesWhenConsumeLogs #11116

Closed
djaglowski opened this issue Jun 17, 2022 · 12 comments · Fixed by #13296
Closed

[exporter/loadbalancing] Flaky Test - TestRollingUpdatesWhenConsumeLogs #11116

djaglowski opened this issue Jun 17, 2022 · 12 comments · Fixed by #13296
Assignees
Labels
bug Something isn't working exporter/loadbalancing flaky test a test is flaky priority:p2 Medium

Comments

@djaglowski
Copy link
Member

djaglowski commented Jun 17, 2022

Observed here: https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/7802139871?check_suite_focus=true#step:7:2604

trace_exporter_test.go:569: 
        	Error Trace:	D:\a\opentelemetry-collector-contrib\opentelemetry-collector-contrib\exporter\loadbalancingexporter\trace_exporter_test.go:569
        	Error:      	"0" is not greater than "0"
        	Test:       	TestRollingUpdatesWhenConsumeTraces
--- FAIL: TestRollingUpdatesWhenConsumeTraces (0.05s)
FAIL
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/loadbalancingexporter	0.306s
FAIL
mingw32-make[2]: *** [../../Makefile.Common:56: test] Error 1

@djaglowski djaglowski added bug Something isn't working flaky test a test is flaky priority:p3 Lowest labels Jun 17, 2022
@jpkrohling jpkrohling self-assigned this Jul 5, 2022
@BinaryFissionGames
Copy link
Contributor

May or may not be related to this specific issue, but another flake on the same test: https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/7749964411?check_suite_focus=true#step:7:2794

=== RUN   TestRollingUpdatesWhenConsumeLogs
    log_exporter_test.go:468: 
        	Error Trace:	D:\a\opentelemetry-collector-contrib\opentelemetry-collector-contrib\exporter\loadbalancingexporter\log_exporter_test.go:468
        	Error:      	"0" is not greater than "0"
        	Test:       	TestRollingUpdatesWhenConsumeLogs
--- FAIL: TestRollingUpdatesWhenConsumeLogs (0.05s)

@djaglowski
Copy link
Member Author

Escalating this to a p2 due to #13220

@djaglowski
Copy link
Member Author

@dmitryax
Copy link
Member

@bogdandrutu
Copy link
Member

The initial problem (race condition) was fixed before @djaglowski disabled the test :)) #13257

Lucky the test is still flaky for a different reason, see https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/7802139871?check_suite_focus=true

@djaglowski can you update the issue please ?

@djaglowski
Copy link
Member Author

Issue updated.

bogdandrutu added a commit to bogdandrutu/opentelemetry-collector-contrib that referenced this issue Aug 12, 2022
bogdandrutu added a commit that referenced this issue Aug 12, 2022
…ondition in the traces (#13296)

Consolidate rolling update tests, fix race condition in the traces

Fixes #11116

Signed-off-by: Bogdan Drutu <[email protected]>

Signed-off-by: Bogdan Drutu <[email protected]>
@dmitryax dmitryax reopened this Aug 12, 2022
@dmitryax
Copy link
Member

@bogdandrutu
Copy link
Member

All of them are for TestRollingUpdatesWhenConsumeTraces not for TestRollingUpdatesWhenConsumeLogs. Looks like a problem on the Traces.

@dmitryax
Copy link
Member

Right. I created another issue for traces #13331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working exporter/loadbalancing flaky test a test is flaky priority:p2 Medium
Projects
None yet
6 participants