Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/tailsampling] support trace_state policy #10852

Merged

Conversation

ralphgj
Copy link
Contributor

@ralphgj ralphgj commented Jun 9, 2022

Description:

Added trace_state sampling policy that allows sampling trace by the TraceState field

Link to tracking Issue:

Testing:
Added unit test to test behavior of trace_state policy and modified configuration test to support the policy

Documentation:
Added usage of trace_state policy for tailsampling processor.

@ralphgj ralphgj requested a review from a team June 9, 2022 09:07
@ralphgj ralphgj requested a review from jpkrohling as a code owner June 9, 2022 09:07
@ralphgj ralphgj force-pushed the support-tracestate-sampling-policy branch from a5e5e19 to d4ea588 Compare June 9, 2022 09:11
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @ralphgj! Just one comment and a question, otherwise it looks good.

@ralphgj ralphgj force-pushed the support-tracestate-sampling-policy branch 2 times, most recently from 766a4f6 to 935cdc2 Compare June 17, 2022 03:06
@ralphgj ralphgj force-pushed the support-tracestate-sampling-policy branch from 935cdc2 to 8666a6d Compare June 17, 2022 15:27
@codeboten codeboten added the ready to merge Code review completed; ready to merge by maintainers label Jun 20, 2022
@codeboten codeboten merged commit 8875a71 into open-telemetry:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants