Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/transform] Optimize the use of trace_state in condition #10849

Closed
ralphgj opened this issue Jun 9, 2022 · 3 comments · Fixed by #11029
Closed

[processor/transform] Optimize the use of trace_state in condition #10849

ralphgj opened this issue Jun 9, 2022 · 3 comments · Fixed by #11029
Assignees
Labels
data:traces Trace related issues enhancement New feature or request good first issue Good for newcomers priority:p3 Lowest processor/transform Transform processor

Comments

@ralphgj
Copy link
Contributor

ralphgj commented Jun 9, 2022

Is your feature request related to a problem? Please describe.
In open-telemetry spec, trace_state is a key-valued struct. Now trace_state seems being used as a string in a condition. Maybe we can make it easier to use.

Describe the solution you'd like
In example, when trace_state having the value of key1=val1,key2=val2 in spans, we can give a query configuration like this:
set(status.code, 1) where trace_state["key1"] == "val1"

@mx-psi mx-psi added enhancement New feature or request data:traces Trace related issues processor/transform Transform processor labels Jun 10, 2022
@djaglowski djaglowski added help wanted Extra attention is needed good first issue Good for newcomers priority:p3 Lowest labels Jun 10, 2022
@codeboten
Copy link
Contributor

@ralphgj any chance you'll be able to help with this one since you've already submitted another trace state related PR?

@ralphgj
Copy link
Contributor Author

ralphgj commented Jun 13, 2022

Of course, I will take a try.

@TylerHelmuth
Copy link
Member

I believe you'll need to add a new accessor function and reuse the logic that attributes uses for key access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:traces Trace related issues enhancement New feature or request good first issue Good for newcomers priority:p3 Lowest processor/transform Transform processor
Projects
None yet
5 participants