Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/loadbalancing] Allow interval and timeout to be customized #10202

Merged

Conversation

jvilhuber
Copy link
Contributor

Description:
Adding resolving interval and timeout to the configuration.

Link to tracking Issue: #10199

Testing: unit tests pass, and I compiled and deployed this in my local testbed with a 30 seconds/ 5 second timeout test.

Documentation: new config options documented in the README.md

jvilhuber added 3 commits May 23, 2022 14:44

Verified

This commit was signed with the committer’s verified signature.
janicduplessis Janic Duplessis

Verified

This commit was signed with the committer’s verified signature.
janicduplessis Janic Duplessis
@jvilhuber jvilhuber requested a review from a team May 23, 2022 08:06
@jvilhuber jvilhuber requested a review from jpkrohling as a code owner May 23, 2022 08:06
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 23, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jvilhuber please sign the CLA 👍

Copy link
Contributor

@pmm-sumo pmm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the CLA missing LGTM :)

@jvilhuber
Copy link
Contributor Author

CLA

Yea, I'm working on it. Sorry for the delay.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 15, 2022
@TylerHelmuth
Copy link
Member

@jvilhuber any news on the CLA?

@jvilhuber
Copy link
Contributor Author

@jvilhuber any news on the CLA?

Still waiting on my company to approve. Sorry about that.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2022

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@jpkrohling
Copy link
Member

What's the state of this PR?

@jvilhuber
Copy link
Contributor Author

What's the state of this PR?

Still waiting for me (or rather my company) to sign the CLA. It's winding its way through the layers. Hopefully soon.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Aug 9, 2022
@jpkrohling jpkrohling reopened this Aug 22, 2022
@jpkrohling jpkrohling changed the title Feature/jvilhuber dns configs [exporter/loadbalancing] Allow interval and timeout to be customized Aug 30, 2022
@jpkrohling jpkrohling merged commit 6e7d72f into open-telemetry:main Aug 30, 2022
@jvilhuber jvilhuber deleted the feature/jvilhuber-dns-configs branch August 31, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants