Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter/loadbalancingexporter: make dns resolver interval and timeout configurable #10199

Closed
jvilhuber opened this issue May 21, 2022 · 3 comments

Comments

@jvilhuber
Copy link
Contributor

jvilhuber commented May 21, 2022

Is your feature request related to a problem? Please describe.
I frequently see these errors in my logs:

{"level":"warn","ts":1653102273.0902977,"caller":"[email protected]/resolver_dns.go:106","msg":"failed to resolve","kind":"exporter","name":"loadbalancing","resolver":"dns","error":"i/o timeout"}

Seems at times the cluster may just be slow and the default 1-second (every 5 seconds) timeout is too short.

Describe the solution you'd like
Make the dns lookup interval and timeout configurable.

Describe alternatives you've considered
No alternative comes to mind. Making the timeout longer across the board may make other environments unstable.

Additional context

@TylerHelmuth
Copy link
Member

Seems like a good addition to the config. @jvilhuber is this something you plan to contribute?

@jvilhuber
Copy link
Contributor Author

I can certainly give it a go! I'm currently waiting for my company to approve the CLA.

@jvilhuber
Copy link
Contributor Author

This was recently fixed/merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants