Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaegerreceiver] Gives warning about "jaeger receiver will deprecate Thrift-gen and replace it with Proto-gen" #35894

Closed
davispuh opened this issue Oct 21, 2024 · 1 comment · Fixed by #36831
Labels
bug Something isn't working receiver/jaeger

Comments

@davispuh
Copy link
Contributor

Component(s)

receiver/jaeger

What happened?

Description

After starting Collector in logs can see warning.

Steps to Reproduce

Note sure, I think need to enable jaegerreceiver

Expected Result

No such warning.

Actual Result

Warning:

{"level":"warn","ts":1729291563.3518195,"caller":"[email protected]/factory.go:49","msg":"jaeger receiver will deprecate Thrift-gen and replace it with Proto-gen to be compatbible to jaeger 1.42.0 and higher. See #18485 for more details.","kind":"receiver","name":"jaeger","data_type":"traces"}

Collector version

v0.111.0

Environment information

Environment

OS: openSUSE Leap 15.6

OpenTelemetry Collector configuration

receivers:
  jaeger:
    protocols:
      grpc:
        endpoint: 0.0.0.0:14250
      thrift_http:
        endpoint: 0.0.0.0:14268

Log output

{"level":"warn","ts":1729291563.3518195,"caller":"[email protected]/factory.go:49","msg":"jaeger receiver will deprecate Thrift-gen and replace it with Proto-gen to be compatbible to jaeger 1.42.0 and higher. See #18485 for more details.","kind":"receiver","name":"jaeger","data_type":"traces"}

Additional context

No response

@davispuh davispuh added bug Something isn't working needs triage New item requiring triage labels Oct 21, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme atoulme removed the needs triage New item requiring triage label Oct 29, 2024
mx-psi pushed a commit that referenced this issue Dec 16, 2024
#### Description
The remote sampling functionality has been already removed from
`jaegerreceiver` in #14163. The logged warning has no impact or meaning.

#### Link to tracking issue
Fixes #35894

#### Testing
CI

---------

Signed-off-by: Yuri Shkuro <[email protected]>
Co-authored-by: Yang Song <[email protected]>
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
#### Description
The remote sampling functionality has been already removed from
`jaegerreceiver` in open-telemetry#14163. The logged warning has no impact or meaning.

#### Link to tracking issue
Fixes open-telemetry#35894

#### Testing
CI

---------

Signed-off-by: Yuri Shkuro <[email protected]>
Co-authored-by: Yang Song <[email protected]>
mterhar pushed a commit to mterhar/opentelemetry-collector-contrib that referenced this issue Dec 19, 2024
The remote sampling functionality has been already removed from
`jaegerreceiver` in open-telemetry#14163. The logged warning has no impact or meaning.

Fixes open-telemetry#35894

CI

---------

Signed-off-by: Yuri Shkuro <[email protected]>
Co-authored-by: Yang Song <[email protected]>
AkhigbeEromo pushed a commit to sematext/opentelemetry-collector-contrib that referenced this issue Jan 13, 2025
#### Description
The remote sampling functionality has been already removed from
`jaegerreceiver` in open-telemetry#14163. The logged warning has no impact or meaning.

#### Link to tracking issue
Fixes open-telemetry#35894

#### Testing
CI

---------

Signed-off-by: Yuri Shkuro <[email protected]>
Co-authored-by: Yang Song <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working receiver/jaeger
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants