Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/servicegraph] documentation inconsistency in README #29723

Closed
rlankfo opened this issue Dec 9, 2023 · 2 comments · Fixed by #29724
Closed

[processor/servicegraph] documentation inconsistency in README #29723

rlankfo opened this issue Dec 9, 2023 · 2 comments · Fixed by #29724
Assignees
@rlankfo
Labels
documentation Improvements or additions to documentation processor/servicegraph Service graph processor

Comments

@rlankfo
Copy link
Member

rlankfo commented Dec 9, 2023

Component(s)

processor/servicegraph

Describe the issue you're reporting

The README indicates the default value of the store TTL is 2ms when this should be 2s:
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/processor/servicegraphprocessor/README.md?plain=1#L122

See the default config:
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/processor/servicegraphprocessor/factory.go#L78
@rlankfo rlankfo added the needs triage New item requiring triage label Dec 9, 2023
@github-actions github-actions bot added the processor/servicegraph Service graph processor label Dec 9, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

This was referenced Dec 9, 2023
Merged
Merged
@crobert-1
Copy link
Member

Good catch, looks like the README is wrong. Thanks for fixing as well!

@crobert-1 crobert-1 added documentation Improvements or additions to documentation and removed needs triage New item requiring triage labels Dec 11, 2023
codeboten pushed a commit that referenced this issue Dec 11, 2023
@rlankfo
update servicegraph processor README typo (#29724)
caad6ff 
Fixes
#29723

Signed-off-by: Robbie Lankford <[email protected]>
@github-actions github-actions bot mentioned this issue Dec 12, 2023
Closed
95 tasks
@rlankfo rlankfo mentioned this issue Feb 7, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlankfo rlankfo

Labels
documentation Improvements or additions to documentation processor/servicegraph Service graph processor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update servicegraph processor README typo rlankfo/opentelemetry-collector-contrib
2 participants
@rlankfo @crobert-1