otelcol.connector.servicegraph: update default store ttl value #5941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robbie Lankford <[email protected]>
clayton-cornell
added
the
type/docs
|
Docs are fine. This touches the .go files so handing off to to someone in the dev team to give it a quick look. |
ptodev
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Thank you for spotting this. I agree that we should change it to 2s, because:
- It is more in line with the Collector
- 2s seems more useful than 2ms. 2ms seems really short... I doubt that the component would work correctly for most customers if the ttl is just 2ms.
My only concern about this is that customers who use the default values may see a difference in behaviour. But I think that's ok, since 2s is a more useful value. Also, the component is labeled as "experimental", so such changes are expected.
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
…na#5941) * otelcol.connector.servicegraph: update default store ttl value Signed-off-by: Robbie Lankford <[email protected]> * update test --------- Signed-off-by: Robbie Lankford <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robbie Lankford [email protected]
PR Description
This PR updates the default store ttl for this component from 2ms to 2s.
Which issue(s) this PR fixes
See open-telemetry/opentelemetry-collector-contrib#29723
Notes to the Reviewer
PR Checklist