-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backward compatibility check mode #271
Add backward compatibility check mode #271
Conversation
f04d093
to
2fcaafe
Compare
0744a57
to
fd3be67
Compare
fd3be67
to
761f193
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great additiion! Thanks for putting this together.
- I echo Alexandra's concerns around download success. However, I don't feel the need to reapprove on fix.
- I had one other comment on additioinal stability checking we can do, but consider it non-blocking.
semantic-conventions/src/opentelemetry/semconv/templating/compatibility.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thanks for working on it.
Just a question I had while reviewing/reading the issue: Who is the target group of this new task in the tool? Like, when is it going to be executed? During a release of semconv? By SDK authors? Ran automatically as part of a CI/CD in semconv? It's not clear and maybe this should be stated somewhere?
semantic-conventions/src/tests/data/compat/enum_value_removed/vprev.yaml
Outdated
Show resolved
Hide resolved
semantic-conventions/src/tests/data/markdown/enum_extend_list/expected.md
Outdated
Show resolved
Hide resolved
@joaopgrassi my intention is to add it to CI checks - here's draft PR that demonstrates it open-telemetry/semantic-conventions#764 |
Implements back-compat checks against released version
See open-telemetry/semantic-conventions#740 for the context
Usage:
-f path/to/semantic-conventions/model compatibility --previous-version 1.24.0
If I run it against current semconv main, I get