lint

open-telemetry · Feb 20, 2024 · f04d093 · f04d093
1 parent 208caee
commit f04d093
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/semantic-conventions/dev-requirements.txt b/semantic-conventions/dev-requirements.txt
@@ -4,4 +4,4 @@ pytest==8.0.1
 flake8==7.0.0
 pylint==3.0.3
 isort==5.13.2
-requests=2.31.0
+requests==2.31.0
diff --git a/semantic-conventions/src/opentelemetry/semconv/model/semantic_attribute.py b/semantic-conventions/src/opentelemetry/semconv/model/semantic_attribute.py
@@ -179,7 +179,7 @@ def parse(
 
             tag = attribute.get("tag", "").strip()
             stability = SemanticAttribute.parse_stability(
-                attribute.get("stability"), position_data, not strict_validation
+                attribute.get("stability"), position_data, strict_validation
             )
             deprecated = SemanticAttribute.parse_deprecated(
                 attribute.get("deprecated"), position_data
@@ -282,7 +282,7 @@ def parse_attribute(attribute):
         return attr_type, str(brief), examples
 
     @staticmethod
-    def parse_stability(stability, position_data, ignore_deprecated=False):
+    def parse_stability(stability, position_data, strict_validation=True):
         if stability is None:
             return StabilityLevel.EXPERIMENTAL
 
@@ -296,7 +296,7 @@ def parse_stability(stability, position_data, ignore_deprecated=False):
 
         # TODO: remove this branch - it's necessary for now to allow back-compat checks against old spec versions
         # where we used 'deprecated' as stability level
-        if ignore_deprecated and stability == "deprecated":
+        if not strict_validation and stability == "deprecated":
             print(
                 'WARNING: Using "deprecated" as stability level is no longer supported. Use "experimental" instead.'
             )

diff --git a/semantic-conventions/src/opentelemetry/semconv/model/semantic_convention.py b/semantic-conventions/src/opentelemetry/semconv/model/semantic_convention.py
@@ -142,7 +142,7 @@ def __init__(self, group, strict_validation=True):
         self.prefix = group.get("prefix", "").strip()
         position_data = group.lc.data
         self.stability = SemanticAttribute.parse_stability(
-            group.get("stability"), position_data, not strict_validation
+            group.get("stability"), position_data, strict_validation
         )
         self.deprecated = SemanticAttribute.parse_deprecated(
             group.get("deprecated"), position_data

diff --git a/semantic-conventions/src/opentelemetry/semconv/templating/markdown/options.py b/semantic-conventions/src/opentelemetry/semconv/templating/markdown/options.py
@@ -19,7 +19,6 @@
 @dataclass()
 class MarkdownOptions:
     check_only: bool = False
-    check_compatibility_with: str = None
     enable_stable: bool = False
     enable_experimental: bool = False
     enable_deprecated: bool = True