Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate initial variable values from OspSystemStructure #604

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

eidekrist
Copy link
Member

Closes #597

The problem described in the issue was most likely caused by instantiating an FMU and terminating it before initializing, again caused by attempting to apply an initial value for a non-existing variable after the FMU was loaded. osp_config_parser did not use the proper validating method when adding initial variable values to the system structure.

@eidekrist eidekrist added the bug Something isn't working label Jun 24, 2020
@eidekrist eidekrist self-assigned this Jun 24, 2020
Copy link
Member

@kyllingstad kyllingstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@eidekrist eidekrist merged commit 0349ef1 into master Jun 29, 2020
@eidekrist eidekrist deleted the bugfix/597-validate-initial-values branch June 29, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process hangs when loading OspSystemStructure.xml with invalid parameter name
2 participants