Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process hangs when loading OspSystemStructure.xml with invalid parameter name #597

Closed
ljamt opened this issue Jun 4, 2020 · 4 comments · Fixed by #604
Closed

Process hangs when loading OspSystemStructure.xml with invalid parameter name #597

ljamt opened this issue Jun 4, 2020 · 4 comments · Fixed by #604
Labels
bug Something isn't working

Comments

@ljamt
Copy link
Member

ljamt commented Jun 4, 2020 •
edited
Loading

Have not done any debugging with libcosim, but experiencing the following in the applications.

Cosim Demo App:
Application hangs when loading a OspSystemStructure.xml defining initial value for a non-existing variable. Invalid configuration should have been detected and error message given to the user.

cosim
application hangs on cosim run path-to-invalid-config
@ljamt
Copy link
Member Author

ljamt commented Jun 4, 2020

Experiencing the same when testing with cosim, so I'll moving this issue to libcosim.

@ljamt ljamt transferred this issue from open-simulation-platform/cosim-demo-app Jun 4, 2020
@ljamt ljamt changed the title App hangs when loading config with invalid parameter name Process hangs when loading OspSystemStructure.xml with invalid parameter name Jun 4, 2020
@ljamt ljamt added the bug Something isn't working label Jun 4, 2020
@eidekrist
Copy link
Member

I have tested this with the following Windows builds:

  • cosim-demo-app v0.7.0 - release
  • cosim-demo-app current dev version - debug
  • libcosimc 0.8.0 - debug
  • cosim 0.8.0 - debug
  • libcosim 0.8.0 - debug

I cannot reproduce this with an OspSystemStructure.xml specifying an initial value for a non-existing variable. Do you have a setup you can share?

@ljamt
Copy link
Member Author

ljamt commented Jun 23, 2020

Do you have a setup you can share?

Sent you an example by email.

@eidekrist
Copy link
Member

Sent you an example by email.

From debugging it looks like our old friend terminate before initialize. Some FMU's don't handle this very well, and I think that is what is happening here. It should be solvable by validating initial values before loading FMUs.

eidekrist added a commit that referenced this issue Jun 24, 2020
@eidekrist
#597 Replace initial_values.emplace() with add_variable_value()
1e551c6
@eidekrist eidekrist mentioned this issue Jun 24, 2020
Merged
eidekrist added a commit that referenced this issue Jun 29, 2020
@eidekrist
#597 Replace initial_values.emplace() with add_variable_value() (#604)
0349ef1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate initial variable values from OspSystemStructure open-simulation-platform/libcosim
2 participants
@ljamt @eidekrist