Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for vector sum connections #517

Merged
merged 10 commits into from
Feb 6, 2020
Merged

Support for vector sum connections #517

merged 10 commits into from
Feb 6, 2020

Conversation

eidekrist
Copy link
Member

Closes #516.

Mob session work.

@eidekrist eidekrist added the enhancement New feature or request label Jan 22, 2020
@eidekrist
Copy link
Member Author

eidekrist commented Jan 23, 2020 •
edited
Loading

Looks like I forgot to commit vector.fmu. It also needs to be cross compiled, but I have totally forgotten how to. @hplatou showed me once, but as he is on vacay, is anyone else up for the task?
Edit: I got'er done.

@ljamt ljamt mentioned this pull request Jan 28, 2020
Merged
4 tasks
@eidekrist
Copy link
Member Author

I've pushed an update where the generic Function XML elements are replaced with explicit types for each currently supported function type, as described above. I also decided it would be a (good) idea to update the C++ structures representing the XML to match, so there a a lot more code changes than I first anticipated. It will take more code to implement new function types, but on the upside it is (in my opinion) easier to write the parsing & handling code for a function type.

kyllingstad
kyllingstad approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@kyllingstad kyllingstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eidekrist eidekrist merged commit ef8a9aa into master Feb 6, 2020
@eidekrist eidekrist deleted the feature/516-vector-sum-connections branch February 6, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljamt ljamt ljamt left review comments

@kyllingstad kyllingstad kyllingstad approved these changes

@hplatou hplatou Awaiting requested review from hplatou

@mrindar mrindar Awaiting requested review from mrindar

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support vector sum connection
4 participants
@eidekrist @kyllingstad @ljamt @mrindar