feat: add `UserSettings` component to design system #788

OgDev-01 · 2023-01-16T20:28:43Z

What type of PR is this? (check all applicable)

Description

Th PR:

creates a LanguagePill component to the atoms directory
adds LanguagePill to design system
adds the user settings screen to the storybook(design system)
updates existing checkbox style to match the brand color

Notes:

This has no functionality yet, just the UI
The current UI checkbox was replaced with the default checkbox in the design system

Related Tickets & Documents

Fixes #783

Mobile & Desktop Screenshots/Recordings

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify · 2023-01-16T20:28:48Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`30c28a4`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/63cea6dc1d9b5400090d3888
😎 Deploy Preview	https://deploy-preview-788--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2023-01-16T20:28:49Z

✅ Deploy Preview for oss-insights ready!

Name	Link
🔨 Latest commit	`30c28a4`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/63cea6dc8420f10008b82e5d
😎 Deploy Preview	https://deploy-preview-788--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

…83-user-settings

bdougie · 2023-01-19T14:37:15Z

I want to point out the importance of #791 😂

This Page is not in the Page folder. Not a big deal, but just pointing out the confusion of our current design system setup.

bdougie

We should provide the list of timezones in the dropdown.

This should be in a lib - https://stackoverflow.com/questions/38399465/how-to-get-list-of-all-timezones-in-javascript

Perhaps it can be done in a new PR though

components/atoms/LanguagePill/LanguagePill.tsx

components/organisms/UserSettingsPage/user-settings-page.tsx

components/atoms/LanguagePill/LanguagePill.tsx

components/organisms/UserSettingsPage/user-settings-page.tsx

Co-authored-by: Brandon <[email protected]>

github-actions

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Watched Files

This pull request modifies specific files that require careful review by the maintainers.

Files Matched

npm-shrinkwrap.json
package.json

OgDev-01 · 2023-01-19T16:34:38Z

We should provide the list of timezones in the dropdown.

This should be in a lib - https://stackoverflow.com/questions/38399465/how-to-get-list-of-all-timezones-in-javascript
Perhaps it can be done in a new PR though

Opening a new issue to implement the form functionality, and this can be included also🍕

…sights into 783-user-settings

brandonroberts · 2023-01-19T16:53:40Z

@bdougie A general observation, but can we separate updating Email Preferences from Profile. There isn't a clear distinction between the two sections.

bdougie · 2023-01-19T16:59:35Z

Yes, my original thought was adding it on the right. But wasn't sure if it would get buried on mobile.

OgDev-01 · 2023-01-19T17:07:15Z

Yes, my original thought was adding it on the right. But wasn't sure if it would get buried on mobile.

That section can go under/above the interest section on mobile... any of both would look good on mobile

I can as well push updates for it in a few minutes 🍕

bdougie · 2023-01-19T20:32:27Z

Everything should float left on large screens.

OgDev-01 · 2023-01-20T17:57:53Z

Everything should float left on large screens.

This is just the form component without a wrapper... once it is plugged into a page the wrapper will be used to handle the float 🍕

components/organisms/UserSettingsPage/user-settings-page.tsx

Co-authored-by: Brandon <[email protected]>

brandonroberts · 2023-01-24T14:01:27Z

We will adjust the timezone fields in implementation

## [1.25.0-beta.6](v1.25.0-beta.5...v1.25.0-beta.6) (2023-01-24) ### 🍕 Features * add `UserSettings` component to design system ([#788](#788)) ([dd9cabd](dd9cabd)), closes [#783](#783) ### 🐛 Bug Fixes * mobile insights header layout break ([#795](#795)) ([0bc2f0b](0bc2f0b)), closes [#769](#769)

github-actions · 2023-01-24T14:09:47Z

🎉 This PR is included in version 1.25.0-beta.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.25.0](v1.24.0...v1.25.0) (2023-01-30) ### 🧑‍💻 Code Refactoring * Renamed the ContributorTable to PullRequestTable ([#779](#779)) ([694d213](694d213)), closes [#681](#681) ### 🐛 Bug Fixes * add fix for Storybook usage with Next 13 ([#792](#792)) ([bb10b2b](bb10b2b)), closes [/github.com/vercel/next.js/issues/36417#issuecomment-1117360509](https://github.com/open-sauced//github.com/vercel/next.js/issues/36417/issues/issuecomment-1117360509) * correct repositories empty list message ([#778](#778)) ([18b7393](18b7393)), closes [#777](#777) * make repositories table styles more responsive ([#773](#773)) ([fe5c6f5](fe5c6f5)), closes [#724](#724) * mobile insights header layout break ([#795](#795)) ([0bc2f0b](0bc2f0b)), closes [#769](#769) * remove usage of next/legacy/image ([#793](#793)) ([9264ffb](9264ffb)) * revert [#778](#778) ([f6e30e1](f6e30e1)) * use correct avatar URL for caching ([#800](#800)) ([726f11b](726f11b)), closes [#757](#757) [#746](#746) ### 🍕 Features * add `PullRequestSocialCard` component to design system ([#774](#774)) ([04600c2](04600c2)), closes [#716](#716) * add `UserSettings` component to design system ([#788](#788)) ([dd9cabd](dd9cabd)), closes [#783](#783) * set insight repo limit based on role ([#813](#813)) ([9e998f1](9e998f1)) * update to Next 13.1.x ([#758](#758)) ([72c2b64](72c2b64)), closes [#753](#753)

github-actions · 2023-01-30T17:50:29Z

🎉 This PR is included in version 1.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

* v1.25.0-beta.10 -> production (#815) * chore(minor): release 1.25.0 [skip ci] ## [1.25.0](v1.24.0...v1.25.0) (2023-01-30) ### 🧑‍💻 Code Refactoring * Renamed the ContributorTable to PullRequestTable ([#779](#779)) ([694d213](694d213)), closes [#681](#681) ### 🐛 Bug Fixes * add fix for Storybook usage with Next 13 ([#792](#792)) ([bb10b2b](bb10b2b)), closes [/github.com/vercel/next.js/issues/36417#issuecomment-1117360509](https://github.com/open-sauced//github.com/vercel/next.js/issues/36417/issues/issuecomment-1117360509) * correct repositories empty list message ([#778](#778)) ([18b7393](18b7393)), closes [#777](#777) * make repositories table styles more responsive ([#773](#773)) ([fe5c6f5](fe5c6f5)), closes [#724](#724) * mobile insights header layout break ([#795](#795)) ([0bc2f0b](0bc2f0b)), closes [#769](#769) * remove usage of next/legacy/image ([#793](#793)) ([9264ffb](9264ffb)) * revert [#778](#778) ([f6e30e1](f6e30e1)) * use correct avatar URL for caching ([#800](#800)) ([726f11b](726f11b)), closes [#757](#757) [#746](#746) ### 🍕 Features * add `PullRequestSocialCard` component to design system ([#774](#774)) ([04600c2](04600c2)), closes [#716](#716) * add `UserSettings` component to design system ([#788](#788)) ([dd9cabd](dd9cabd)), closes [#783](#783) * set insight repo limit based on role ([#813](#813)) ([9e998f1](9e998f1)) * update to Next 13.1.x ([#758](#758)) ([72c2b64](72c2b64)), closes [#753](#753)

## [1.25.0-beta.6](open-sauced/app@v1.25.0-beta.5...v1.25.0-beta.6) (2023-01-24) ### 🍕 Features * add `UserSettings` component to design system ([#788](open-sauced/app#788)) ([dd9cabd](open-sauced/app@dd9cabd)), closes [#783](open-sauced/app#783) ### 🐛 Bug Fixes * mobile insights header layout break ([#795](open-sauced/app#795)) ([0bc2f0b](open-sauced/app@0bc2f0b)), closes [#769](open-sauced/app#769)

## [1.25.0](open-sauced/app@v1.24.0...v1.25.0) (2023-01-30) ### 🧑‍💻 Code Refactoring * Renamed the ContributorTable to PullRequestTable ([#779](open-sauced/app#779)) ([694d213](open-sauced/app@694d213)), closes [#681](open-sauced/app#681) ### 🐛 Bug Fixes * add fix for Storybook usage with Next 13 ([#792](open-sauced/app#792)) ([bb10b2b](open-sauced/app@bb10b2b)), closes [/github.com/vercel/next.js/issues/36417#issuecomment-1117360509](https://github.com/open-sauced//github.com/vercel/next.js/issues/36417/issues/issuecomment-1117360509) * correct repositories empty list message ([#778](open-sauced/app#778)) ([18b7393](open-sauced/app@18b7393)), closes [#777](open-sauced/app#777) * make repositories table styles more responsive ([#773](open-sauced/app#773)) ([fe5c6f5](open-sauced/app@fe5c6f5)), closes [#724](open-sauced/app#724) * mobile insights header layout break ([#795](open-sauced/app#795)) ([0bc2f0b](open-sauced/app@0bc2f0b)), closes [#769](open-sauced/app#769) * remove usage of next/legacy/image ([#793](open-sauced/app#793)) ([9264ffb](open-sauced/app@9264ffb)) * revert [#778](open-sauced/app#778) ([f6e30e1](open-sauced/app@f6e30e1)) * use correct avatar URL for caching ([#800](open-sauced/app#800)) ([726f11b](open-sauced/app@726f11b)), closes [#757](open-sauced/app#757) [#746](open-sauced/app#746) ### 🍕 Features * add `PullRequestSocialCard` component to design system ([#774](open-sauced/app#774)) ([04600c2](open-sauced/app@04600c2)), closes [#716](open-sauced/app#716) * add `UserSettings` component to design system ([#788](open-sauced/app#788)) ([dd9cabd](open-sauced/app@dd9cabd)), closes [#783](open-sauced/app#783) * set insight repo limit based on role ([#813](open-sauced/app#813)) ([9e998f1](open-sauced/app@9e998f1)) * update to Next 13.1.x ([#758](open-sauced/app#758)) ([72c2b64](open-sauced/app@72c2b64)), closes [#753](open-sauced/app#753)

* v1.25.0-beta.10 -> production (#815) * chore(minor): release 1.25.0 [skip ci] ## [1.25.0](open-sauced/app@v1.24.0...v1.25.0) (2023-01-30) ### 🧑‍💻 Code Refactoring * Renamed the ContributorTable to PullRequestTable ([#779](open-sauced/app#779)) ([694d213](open-sauced/app@694d213)), closes [#681](open-sauced/app#681) ### 🐛 Bug Fixes * add fix for Storybook usage with Next 13 ([#792](open-sauced/app#792)) ([bb10b2b](open-sauced/app@bb10b2b)), closes [/github.com/vercel/next.js/issues/36417#issuecomment-1117360509](https://github.com/open-sauced//github.com/vercel/next.js/issues/36417/issues/issuecomment-1117360509) * correct repositories empty list message ([#778](open-sauced/app#778)) ([18b7393](open-sauced/app@18b7393)), closes [#777](open-sauced/app#777) * make repositories table styles more responsive ([#773](open-sauced/app#773)) ([fe5c6f5](open-sauced/app@fe5c6f5)), closes [#724](open-sauced/app#724) * mobile insights header layout break ([#795](open-sauced/app#795)) ([0bc2f0b](open-sauced/app@0bc2f0b)), closes [#769](open-sauced/app#769) * remove usage of next/legacy/image ([#793](open-sauced/app#793)) ([9264ffb](open-sauced/app@9264ffb)) * revert [#778](open-sauced/app#778) ([f6e30e1](open-sauced/app@f6e30e1)) * use correct avatar URL for caching ([#800](open-sauced/app#800)) ([726f11b](open-sauced/app@726f11b)), closes [#757](open-sauced/app#757) [#746](open-sauced/app#746) ### 🍕 Features * add `PullRequestSocialCard` component to design system ([#774](open-sauced/app#774)) ([04600c2](open-sauced/app@04600c2)), closes [#716](open-sauced/app#716) * add `UserSettings` component to design system ([#788](open-sauced/app#788)) ([dd9cabd](open-sauced/app@dd9cabd)), closes [#783](open-sauced/app#783) * set insight repo limit based on role ([#813](open-sauced/app#813)) ([9e998f1](open-sauced/app@9e998f1)) * update to Next 13.1.x ([#758](open-sauced/app#758)) ([72c2b64](open-sauced/app@72c2b64)), closes [#753](open-sauced/app#753)

OgDev-01 added 4 commits January 16, 2023 21:24

chore: add radix checkbox

8ed0ae0

refactor: replace supabase to radix

adc69af

feat: create user Settings update page

b49d8b4

docs: add user settings page to design system

8e9764e

OgDev-01 added 8 commits January 17, 2023 18:54

Merge branch 'beta' of https://github.com/open-sauced/insights into 7…

74798cb

…83-user-settings

chore: add required assets

9068ae1

feat: create language pill

9785d19

feat: create user settings page component

8f5892b

docs: add user settings to storybook

c417f85

refactor: update checkbox color

0d33d02

chore: finishing touches

df105bd

style: repsonsive fixes

8fa7d7f

OgDev-01 requested a review from 0-vortex January 19, 2023 14:24

OgDev-01 marked this pull request as ready for review January 19, 2023 14:24

OgDev-01 requested review from bdougie and brandonroberts January 19, 2023 14:25

bdougie reviewed Jan 19, 2023

View reviewed changes

brandonroberts requested changes Jan 19, 2023

View reviewed changes

OgDev-01 and others added 2 commits January 19, 2023 17:20

Update components/organisms/UserSettingsPage/user-settings-page.tsx

9461613

Co-authored-by: Brandon <[email protected]>

Update components/atoms/LanguagePill/LanguagePill.tsx

b0b1b81

Co-authored-by: Brandon <[email protected]>

github-actions bot reviewed Jan 19, 2023

View reviewed changes

OgDev-01 added 2 commits January 19, 2023 17:37

refactor: minor changes

9be5c11

Merge branch '783-user-settings' of https://github.com/open-sauced/in…

581ec1e

…sights into 783-user-settings

OgDev-01 mentioned this pull request Jan 19, 2023

feat: implement UserSettings page #794

Closed

style: update styling and layout

cedd529

OgDev-01 requested review from brandonroberts and bdougie January 23, 2023 14:45

brandonroberts approved these changes Jan 23, 2023

View reviewed changes

components/organisms/UserSettingsPage/user-settings-page.tsx Outdated Show resolved Hide resolved

brandonroberts changed the title ~~feat: Add UserSettings component to design system~~ feat: add UserSettings component to design system Jan 23, 2023

Update components/organisms/UserSettingsPage/user-settings-page.tsx

30c28a4

Co-authored-by: Brandon <[email protected]>

OgDev-01 added the needs review PRs that need review from core engineering team label Jan 24, 2023

brandonroberts merged commit dd9cabd into beta Jan 24, 2023

brandonroberts deleted the 783-user-settings branch January 24, 2023 14:01

github-actions bot added the released on @beta label Jan 24, 2023

github-actions bot added the released label Jan 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add `UserSettings` component to design system #788

feat: add `UserSettings` component to design system #788

OgDev-01 commented Jan 16, 2023 •

edited

Loading

netlify bot commented Jan 16, 2023 •

edited

Loading

netlify bot commented Jan 16, 2023 •

edited

Loading

bdougie commented Jan 19, 2023

bdougie left a comment •

edited

Loading

github-actions bot left a comment

OgDev-01 commented Jan 19, 2023

brandonroberts commented Jan 19, 2023

bdougie commented Jan 19, 2023

OgDev-01 commented Jan 19, 2023 •

edited

Loading

bdougie commented Jan 19, 2023

OgDev-01 commented Jan 20, 2023

brandonroberts commented Jan 24, 2023

github-actions bot commented Jan 24, 2023

github-actions bot commented Jan 30, 2023

feat: add UserSettings component to design system #788

feat: add UserSettings component to design system #788

Conversation

OgDev-01 commented Jan 16, 2023 • edited Loading

What type of PR is this? (check all applicable)

Description

Notes:

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify bot commented Jan 16, 2023 • edited Loading

✅ Deploy Preview for design-insights ready!

netlify bot commented Jan 16, 2023 • edited Loading

✅ Deploy Preview for oss-insights ready!

bdougie commented Jan 19, 2023

bdougie left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

PR Compliance Checks

Watched Files

OgDev-01 commented Jan 19, 2023

brandonroberts commented Jan 19, 2023

bdougie commented Jan 19, 2023

OgDev-01 commented Jan 19, 2023 • edited Loading

bdougie commented Jan 19, 2023

OgDev-01 commented Jan 20, 2023

brandonroberts commented Jan 24, 2023

github-actions bot commented Jan 24, 2023

github-actions bot commented Jan 30, 2023

feat: add `UserSettings` component to design system #788

feat: add `UserSettings` component to design system #788

OgDev-01 commented Jan 16, 2023 •

edited

Loading

netlify bot commented Jan 16, 2023 •

edited

Loading

netlify bot commented Jan 16, 2023 •

edited

Loading

bdougie left a comment •

edited

Loading

OgDev-01 commented Jan 19, 2023 •

edited

Loading