Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: getAvatarLink is using the redirect link #746

Closed
2 tasks done
0-vortex opened this issue Dec 29, 2022 · 2 comments · Fixed by #800
Closed
2 tasks done

Bug: getAvatarLink is using the redirect link #746

0-vortex opened this issue Dec 29, 2022 · 2 comments · Fixed by #800
Assignees
@takanome-dev
Labels
🐛 bug Something isn't working 👀 needs triage released on @beta released

Comments

@0-vortex
Copy link
Contributor

Describe the bug

Proposal would be diverging the existing getAvatarLink into getAvatarByUsername and another meta function getAvatarById, then slowly offsetting getAvatarByUsername in favour of the more efficient getAvatarById

Steps to reproduce

getAvatarLink is using the aliased username link that redirects to the user_id - this is a neat way to figure out a user's github id by looking at their picture, but not a good way to load pictures.

Affected services

insights.opensauced.pizza

Platforms

No response

Browsers

No response

Environment

No response

Additional context

tooling, QoL, !GFI

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@0-vortex 0-vortex added 🐛 bug Something isn't working 👀 needs triage labels Dec 29, 2022
@takanome-dev takanome-dev self-assigned this Jan 26, 2023
@takanome-dev takanome-dev mentioned this issue Jan 26, 2023
Merged
19 tasks
brandonroberts pushed a commit that referenced this issue Jan 26, 2023
@takanome-dev
fix: use correct avatar URL for caching (#800)
726f11b 
Fixes #757
Fixes #746
github-actions bot pushed a commit that referenced this issue Jan 26, 2023
@takanome-dev @open-sauced
chore(patch): release 1.25.0-beta.9 on beta channel [skip ci]
4a232c9 
## [1.25.0-beta.9](v1.25.0-beta.8...v1.25.0-beta.9) (2023-01-26)

### 🐛 Bug Fixes

* use correct avatar URL for caching  ([#800](#800)) ([726f11b](726f11b)), closes [#757](#757) [#746](#746)
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.25.0-beta.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Jan 30, 2023
@brandonroberts @open-sauced
chore(minor): release 1.25.0 [skip ci]
cb25b0f 
## [1.25.0](v1.24.0...v1.25.0) (2023-01-30)

### 🧑‍💻 Code Refactoring

* Renamed the ContributorTable to PullRequestTable ([#779](#779)) ([694d213](694d213)), closes [#681](#681)

### 🐛 Bug Fixes

* add fix for Storybook usage with Next 13 ([#792](#792)) ([bb10b2b](bb10b2b)), closes [/github.com/vercel/next.js/issues/36417#issuecomment-1117360509](https://github.com/open-sauced//github.com/vercel/next.js/issues/36417/issues/issuecomment-1117360509)
* correct repositories empty list message ([#778](#778)) ([18b7393](18b7393)), closes [#777](#777)
* make repositories table styles more responsive ([#773](#773)) ([fe5c6f5](fe5c6f5)), closes [#724](#724)
* mobile insights header layout break ([#795](#795)) ([0bc2f0b](0bc2f0b)), closes [#769](#769)
* remove usage of next/legacy/image ([#793](#793)) ([9264ffb](9264ffb))
* revert [#778](#778) ([f6e30e1](f6e30e1))
* use correct avatar URL for caching  ([#800](#800)) ([726f11b](726f11b)), closes [#757](#757) [#746](#746)

### 🍕 Features

* add `PullRequestSocialCard` component to design system ([#774](#774)) ([04600c2](04600c2)), closes [#716](#716)
* add `UserSettings` component to design system ([#788](#788)) ([dd9cabd](dd9cabd)), closes [#783](#783)
* set insight repo limit based on role ([#813](#813)) ([9e998f1](9e998f1))
* update to Next 13.1.x ([#758](#758)) ([72c2b64](72c2b64)), closes [#753](#753)
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

brandonroberts added a commit that referenced this issue Jan 30, 2023
@brandonroberts
chore(minor): release 1.25.0 [skip ci] (#818)
050a4b4 
* v1.25.0-beta.10 -> production (#815)

* chore(minor): release 1.25.0 [skip ci]

## [1.25.0](v1.24.0...v1.25.0) (2023-01-30)

### 🧑‍💻 Code Refactoring

* Renamed the ContributorTable to PullRequestTable ([#779](#779)) ([694d213](694d213)), closes [#681](#681)

### 🐛 Bug Fixes

* add fix for Storybook usage with Next 13 ([#792](#792)) ([bb10b2b](bb10b2b)), closes [/github.com/vercel/next.js/issues/36417#issuecomment-1117360509](https://github.com/open-sauced//github.com/vercel/next.js/issues/36417/issues/issuecomment-1117360509)
* correct repositories empty list message ([#778](#778)) ([18b7393](18b7393)), closes [#777](#777)
* make repositories table styles more responsive ([#773](#773)) ([fe5c6f5](fe5c6f5)), closes [#724](#724)
* mobile insights header layout break ([#795](#795)) ([0bc2f0b](0bc2f0b)), closes [#769](#769)
* remove usage of next/legacy/image ([#793](#793)) ([9264ffb](9264ffb))
* revert [#778](#778) ([f6e30e1](f6e30e1))
* use correct avatar URL for caching  ([#800](#800)) ([726f11b](726f11b)), closes [#757](#757) [#746](#746)

### 🍕 Features

* add `PullRequestSocialCard` component to design system ([#774](#774)) ([04600c2](04600c2)), closes [#716](#716)
* add `UserSettings` component to design system ([#788](#788)) ([dd9cabd](dd9cabd)), closes [#783](#783)
* set insight repo limit based on role ([#813](#813)) ([9e998f1](9e998f1))
* update to Next 13.1.x ([#758](#758)) ([72c2b64](72c2b64)), closes [#753](#753)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
@ElpisHelle
chore(patch): release 1.25.0-beta.9 on beta channel [skip ci]
fd71ece 
## [1.25.0-beta.9](open-sauced/app@v1.25.0-beta.8...v1.25.0-beta.9) (2023-01-26)

### 🐛 Bug Fixes

* use correct avatar URL for caching  ([#800](open-sauced/app#800)) ([726f11b](open-sauced/app@726f11b)), closes [#757](open-sauced/app#757) [#746](open-sauced/app#746)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
@ElpisHelle
chore(minor): release 1.25.0 [skip ci]
5967c0e 
## [1.25.0](open-sauced/app@v1.24.0...v1.25.0) (2023-01-30)

### 🧑‍💻 Code Refactoring

* Renamed the ContributorTable to PullRequestTable ([#779](open-sauced/app#779)) ([694d213](open-sauced/app@694d213)), closes [#681](open-sauced/app#681)

### 🐛 Bug Fixes

* add fix for Storybook usage with Next 13 ([#792](open-sauced/app#792)) ([bb10b2b](open-sauced/app@bb10b2b)), closes [/github.com/vercel/next.js/issues/36417#issuecomment-1117360509](https://github.com/open-sauced//github.com/vercel/next.js/issues/36417/issues/issuecomment-1117360509)
* correct repositories empty list message ([#778](open-sauced/app#778)) ([18b7393](open-sauced/app@18b7393)), closes [#777](open-sauced/app#777)
* make repositories table styles more responsive ([#773](open-sauced/app#773)) ([fe5c6f5](open-sauced/app@fe5c6f5)), closes [#724](open-sauced/app#724)
* mobile insights header layout break ([#795](open-sauced/app#795)) ([0bc2f0b](open-sauced/app@0bc2f0b)), closes [#769](open-sauced/app#769)
* remove usage of next/legacy/image ([#793](open-sauced/app#793)) ([9264ffb](open-sauced/app@9264ffb))
* revert [#778](open-sauced/app#778) ([f6e30e1](open-sauced/app@f6e30e1))
* use correct avatar URL for caching  ([#800](open-sauced/app#800)) ([726f11b](open-sauced/app@726f11b)), closes [#757](open-sauced/app#757) [#746](open-sauced/app#746)

### 🍕 Features

* add `PullRequestSocialCard` component to design system ([#774](open-sauced/app#774)) ([04600c2](open-sauced/app@04600c2)), closes [#716](open-sauced/app#716)
* add `UserSettings` component to design system ([#788](open-sauced/app#788)) ([dd9cabd](open-sauced/app@dd9cabd)), closes [#783](open-sauced/app#783)
* set insight repo limit based on role ([#813](open-sauced/app#813)) ([9e998f1](open-sauced/app@9e998f1))
* update to Next 13.1.x ([#758](open-sauced/app#758)) ([72c2b64](open-sauced/app@72c2b64)), closes [#753](open-sauced/app#753)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
@ElpisHelle
chore(minor): release 1.25.0 [skip ci] (#818)
0be6ac4 
* v1.25.0-beta.10 -> production (#815)

* chore(minor): release 1.25.0 [skip ci]

## [1.25.0](open-sauced/app@v1.24.0...v1.25.0) (2023-01-30)

### 🧑‍💻 Code Refactoring

* Renamed the ContributorTable to PullRequestTable ([#779](open-sauced/app#779)) ([694d213](open-sauced/app@694d213)), closes [#681](open-sauced/app#681)

### 🐛 Bug Fixes

* add fix for Storybook usage with Next 13 ([#792](open-sauced/app#792)) ([bb10b2b](open-sauced/app@bb10b2b)), closes [/github.com/vercel/next.js/issues/36417#issuecomment-1117360509](https://github.com/open-sauced//github.com/vercel/next.js/issues/36417/issues/issuecomment-1117360509)
* correct repositories empty list message ([#778](open-sauced/app#778)) ([18b7393](open-sauced/app@18b7393)), closes [#777](open-sauced/app#777)
* make repositories table styles more responsive ([#773](open-sauced/app#773)) ([fe5c6f5](open-sauced/app@fe5c6f5)), closes [#724](open-sauced/app#724)
* mobile insights header layout break ([#795](open-sauced/app#795)) ([0bc2f0b](open-sauced/app@0bc2f0b)), closes [#769](open-sauced/app#769)
* remove usage of next/legacy/image ([#793](open-sauced/app#793)) ([9264ffb](open-sauced/app@9264ffb))
* revert [#778](open-sauced/app#778) ([f6e30e1](open-sauced/app@f6e30e1))
* use correct avatar URL for caching  ([#800](open-sauced/app#800)) ([726f11b](open-sauced/app@726f11b)), closes [#757](open-sauced/app#757) [#746](open-sauced/app#746)

### 🍕 Features

* add `PullRequestSocialCard` component to design system ([#774](open-sauced/app#774)) ([04600c2](open-sauced/app@04600c2)), closes [#716](open-sauced/app#716)
* add `UserSettings` component to design system ([#788](open-sauced/app#788)) ([dd9cabd](open-sauced/app@dd9cabd)), closes [#783](open-sauced/app#783)
* set insight repo limit based on role ([#813](open-sauced/app#813)) ([9e998f1](open-sauced/app@9e998f1))
* update to Next 13.1.x ([#758](open-sauced/app#758)) ([72c2b64](open-sauced/app@72c2b64)), closes [#753](open-sauced/app#753)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@takanome-dev takanome-dev

Labels
🐛 bug Something isn't working 👀 needs triage released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: fix avatar caching issue takanome-dev/insights
2 participants
@0-vortex @takanome-dev