Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use trunk version of rxcpp. Resolves #122 #127

Merged
merged 3 commits into from
Sep 30, 2021
Merged

Use trunk version of rxcpp. Resolves #122 #127

merged 3 commits into from
Sep 30, 2021

Conversation

arjo129
Copy link
Member

@arjo129 arjo129 commented Sep 27, 2021

Signed-off-by: Arjo Chakravarty [email protected]

@mxgrey
Copy link
Contributor

mxgrey commented Sep 27, 2021

We should make sure to incorporate the changes in this RxCpp PR.

@arjo129 arjo129 linked an issue Sep 27, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #127 (69b4edc) into main (78e85e6) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   21.44%   21.40%   -0.04%     
==========================================
  Files         210      840     +630     
  Lines       16958    67896   +50938     
  Branches     8071    32304   +24233     
==========================================
+ Hits         3636    14532   +10896     
- Misses       9413    37696   +28283     
- Partials     3909    15668   +11759     
Flag Coverage Δ
tests 21.40% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._rxcpp/RxCpp-4.1.0/Rx/v2/src/rxcpp/rx-observer.hpp
...f_fleet_adapter/test/phases/MockAdapterFixture.cpp
....0/Rx/v2/src/rxcpp/operators/rx-combine_latest.hpp
...tw3k/rmf_ros2/rmf_fleet_adapter/test/test_Task.cpp
...ter/src/rmf_fleet_adapter/phases/WaitForCharge.cpp
...eet_adapter/src/rmf_fleet_adapter/phases/Utils.cpp
...mf_fleet_adapter/rmf_rxcpp/test/test_Transport.cpp
...i28gjtw3k/rmf_ros2/rmf_fleet_adapter/test/main.cpp
...ffic_ros2/src/rmf_traffic_ros2/blockade/Writer.cpp
...p/RxCpp-4.1.0/Rx/v2/src/rxcpp/operators/rx-map.hpp
... and 1040 more

@mxgrey mxgrey self-requested a review September 30, 2021 02:08
Copy link
Contributor

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting these files updated!

@mxgrey mxgrey merged commit 081b3e3 into main Sep 30, 2021
@mxgrey mxgrey deleted the arjo/update_rxcpp branch September 30, 2021 07:35
arjo129 added a commit that referenced this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump RxCpp Version up.
2 participants