New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run optimized constant time tests only on haswell #1082

Merged

dstebila merged 1 commit into main from mb-haswellconstanttime

Aug 31, 2021

Member

baentsch commented Aug 31, 2021

This should allow regular optimized code constant-time testing to pass despite current Valgrind platform limitations.

Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
Does this PR change the the list of algorithms available -- either adding, removing, or renaming? (If so, PRs in OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also be required by the time this is merged.)


          run optimized constant time tests only on haswell

286d8c2

baentsch requested a review from xvzcf as a code owner

August 31, 2021 09:26

baentsch requested a review from jschanck

August 31, 2021 09:26

dstebila approved these changes

View reviewed changes

dstebila merged commit eb9ca19 into main

dstebila deleted the mb-haswellconstanttime branch

August 31, 2021 17:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet