run optimized constant time tests only on haswell (#1082)

open-quantum-safe · Aug 31, 2021 · eb9ca19 · eb9ca19
1 parent 3bc89ee
commit eb9ca19
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -360,7 +360,10 @@ workflows:
           name: constant-time-x64-extensions
           context: openquantumsafe
           CONTAINER: openquantumsafe/ci-ubuntu-bionic-x86_64:latest
-          CMAKE_ARGS: -DOQS_OPT_TARGET=auto -DCMAKE_BUILD_TYPE=Debug -DOQS_ENABLE_TEST_CONSTANT_TIME=ON
+          # building for haswell to avoid generating instructions that valgrind cannot currently handle
+          # TODO: Re-enable target=auto if/when valgrind supports beyond AVX2:
+          # check: https://valgrind.org/info/platforms.html
+          CMAKE_ARGS: -DOQS_OPT_TARGET=haswell -DCMAKE_BUILD_TYPE=Debug -DOQS_ENABLE_TEST_CONSTANT_TIME=ON
           PYTEST_ARGS: --numprocesses=auto -k 'test_constant_time'
       - linux_oqs:
           name: undefined-sanitizer