-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: bump ci to golang 1.20 #2597
Conversation
a241238
to
6bb551f
Compare
@@ -311,9 +310,6 @@ func BenchmarkValidationHandler(b *testing.B) { | |||
}, | |||
} | |||
|
|||
// seed random generator | |||
rand.Seed(time.Now().UnixNano()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Sertac Ozercan <[email protected]>
@maxsmythe @ritazh PTAL when you get a chance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2597 +/- ##
==========================================
- Coverage 53.17% 53.11% -0.06%
==========================================
Files 120 120
Lines 10569 10569
==========================================
- Hits 5620 5614 -6
- Misses 4513 4518 +5
- Partials 436 437 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Xander Grzywinski <[email protected]>
What this PR does / why we need it:
updates CI to Go 1.20
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #2569
Special notes for your reviewer: