Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump ci to golang 1.20 #2597

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Feb 23, 2023

What this PR does / why we need it:
updates CI to Go 1.20

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #2569

Special notes for your reviewer:

@sozercan sozercan force-pushed the golang-120 branch 2 times, most recently from a241238 to 6bb551f Compare February 23, 2023 19:58
@sozercan sozercan marked this pull request as draft February 23, 2023 20:16
@sozercan sozercan changed the title chore: bump to golang 1.20 ci: bump ci to golang 1.20 Feb 23, 2023
@@ -311,9 +310,6 @@ func BenchmarkValidationHandler(b *testing.B) {
},
}

// seed random generator
rand.Seed(time.Now().UnixNano())
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The math/rand package now automatically seeds the global random number generator (used by top-level functions like Float64 and Int) with a random value, and the top-level Seed function has been deprecated.

https://tip.golang.org/doc/go1.20

Signed-off-by: Sertac Ozercan <[email protected]>
@sozercan sozercan marked this pull request as ready for review February 23, 2023 22:36
@sozercan sozercan requested a review from maxsmythe February 23, 2023 22:50
@sozercan sozercan added this to the v3.12.0 milestone Mar 1, 2023
@sozercan
Copy link
Member Author

@maxsmythe @ritazh PTAL when you get a chance

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 46.34% and project coverage change: -0.06 ⚠️

Comparison is base (df9a9d9) 53.17% compared to head (34a4cf6) 53.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2597      +/-   ##
==========================================
- Coverage   53.17%   53.11%   -0.06%     
==========================================
  Files         120      120              
  Lines       10569    10569              
==========================================
- Hits         5620     5614       -6     
- Misses       4513     4518       +5     
- Partials      436      437       +1     
Flag Coverage Δ
unittests 53.11% <46.34%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/gator/reader/read_constraints.go 12.50% <0.00%> (ø)
pkg/gator/verify/printer_go.go 46.78% <0.00%> (ø)
pkg/gator/verify/runner.go 86.03% <80.00%> (ø)
pkg/gator/verify/assertion.go 100.00% <100.00%> (ø)
pkg/gator/verify/filter.go 100.00% <100.00%> (ø)
pkg/gator/verify/read_suites.go 87.17% <100.00%> (ø)
pkg/mutation/match/match.go 96.61% <100.00%> (ø)
pkg/target/matcher.go 89.09% <100.00%> (ø)
pkg/target/target.go 77.64% <100.00%> (ø)
pkg/util/enforcement_action.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sozercan sozercan merged commit 852d1f4 into open-policy-agent:master Mar 24, 2023
@sozercan sozercan deleted the golang-120 branch March 24, 2023 01:45
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Mar 31, 2023
salaxander pushed a commit to salaxander/gatekeeper that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: error obtaining VCS status: exit status 128
4 participants