Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add scannet instance dataset with metrics #1230

Merged
merged 11 commits into from
Mar 9, 2022

Conversation

filaPro
Copy link
Contributor

@filaPro filaPro commented Feb 10, 2022

Add ScanNet instance segmentation dataset with evaluator. Close #1204.

Can you please have a look in general structure (e.g. do we need separate INSTANCE_SEG_DATASETS in registry, can ScanNetInstanceSegDataset be inherited from Custom3DSegDataset, do we load only with_mask_3d and with_seg_3d in LoadAnnotations3D, etc...)

Also lint is broken probably not by this PR.

@ZCMax
Copy link
Collaborator

ZCMax commented Feb 15, 2022

Yes, the lint broken problem will be fixed in this PR https://github.com/open-mmlab/mmdetection3d/pull/1166/files

Copy link
Member

@Tai-Wang Tai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Overall looks good to me. Just need to fix the detailed comments.

@Tai-Wang Tai-Wang changed the title add scannet instance dataset with metrics [Feature] add scannet instance dataset with metrics Feb 16, 2022
@ZCMax
Copy link
Collaborator

ZCMax commented Feb 23, 2022

Can you merge the our latest dev branch to resolve the link problem?

* Bump to v0.18.0 (open-mmlab#1148)

* Update README & getting_started & changelog & version.py

* resolve comments

* Update the required maximum version of mmcv-full

* Update changelog.md

* Update getting_started.md

* Add highlight in changelog.md

* update imvoxelnet citation (open-mmlab#1153)

* deprecate the support for "python setup.py test" (open-mmlab#1164)

* add OpenMMLab website and platform links (open-mmlab#1176)

* [Fix] Update regnet metafile (open-mmlab#1184)

* update regnet metafile

* Add Architechture in RegNet metafile

* fix axis=0 rotation in master branch (open-mmlab#1182)

* [Enhance] support semantic seg in Flip3D augmentation (open-mmlab#1181)

* support semantic seg in flip

* change box_dtype_3d to bbox3d_fields

* add point cloud annotation in doc (open-mmlab#1185)

* [Fix] Fix bug in non-distributed multi-gpu training/testing (open-mmlab#1197)

* Fix bug in non-distributed multi-gpu training/testing

* add deprecated warning to void BC-breaking

* Add missing explanation of cam_intrinsic in the nuScenes dataset doc (open-mmlab#1193)

* [Fix] Fix corner bug in different coordinates (open-mmlab#1212)

* fix corner bug in cam coord

* fix corner bugs in depth & lidar coord

* Bump to v0.18.1 (open-mmlab#1218)

* bump to v0.18.1

* fix comments

* update bazel version (open-mmlab#1223)

* [Fix] fix pointpillars bug on kitti in master branch (open-mmlab#1163)

* fix pointpillars bug on kitti in master branch

* replace with AlignedAnchorGenerator

* Update the installation of MMCV (open-mmlab#1226)

* [Fix] Fix a potential overflow bug when post_max_size is set too large in the circle_nms (open-mmlab#1225)

* [Fix] overflow bug

* [Fix] typo

Co-authored-by: zeyuzeng <[email protected]>
Co-authored-by: zeyu-hello <[email protected]>

* Fix PointRCNN bugs (open-mmlab#1224)

* fix bug to allow pointnet to train in fp16 (open-mmlab#1207)

* fix bug to allow pointnet to train in fp16

* remove unused import

* fix lint

* fix lint for gather_points_cuda.cu

Co-authored-by: peng <[email protected]>

* [Fix] Recheck import sorting (open-mmlab#1242)

* fix missed mmcv

* reinstall pre-commit and recheck

* fix inference_demo.ipynb bug (open-mmlab#1236)

* [Enhance] upgrade PointPillars performace on dev branch (open-mmlab#1166)

* upgrade PointPillars performace on dev branch

* update DynamicPillarFeatureNet

* fix comments

* change to AlignedAnchor3DRangeGenerator

* change to AlignedAnchor3DRangeGenerator

* fix

* replace with AlignedAnchorGenerator

* fix lint

* update using isort

* Bump to v1.0.0.rc0 (open-mmlab#928)

* [Refactor] Main code modification for coordinate system refactor (open-mmlab#677)

* [Enhance] Add script for data update (open-mmlab#774)

* Fixed wrong config paths and fixed a bug in test

* Fixed metafile

* Coord sys refactor (main code)

* Update test_waymo_dataset.py

* Manually resolve conflict

* Removed unused lines and fixed imports

* remove coord2box and box2coord

* update dir_limit_offset

* Some minor improvements

* Removed some \s in comments

* Revert a change

* Change Box3DMode to Coord3DMode where points are converted

* Fix points_in_bbox function

* Fix Imvoxelnet config

* Revert adding a line

* Fix rotation bug when batch size is 0

* Keep sign of dir_scores as before

* Fix several comments

* Add a comment

* Fix docstring

* Add data update scripts

* Fix comments

* fix import (open-mmlab#839)

* [Enhance]  refactor  iou_neg_piecewise_sampler.py (open-mmlab#842)

* [Refactor] Main code modification for coordinate system refactor (open-mmlab#677)

* [Enhance] Add script for data update (open-mmlab#774)

* Fixed wrong config paths and fixed a bug in test

* Fixed metafile

* Coord sys refactor (main code)

* Update test_waymo_dataset.py

* Manually resolve conflict

* Removed unused lines and fixed imports

* remove coord2box and box2coord

* update dir_limit_offset

* Some minor improvements

* Removed some \s in comments

* Revert a change

* Change Box3DMode to Coord3DMode where points are converted

* Fix points_in_bbox function

* Fix Imvoxelnet config

* Revert adding a line

* Fix rotation bug when batch size is 0

* Keep sign of dir_scores as before

* Fix several comments

* Add a comment

* Fix docstring

* Add data update scripts

* Fix comments

* fix import

* refactor iou_neg_piecewise_sampler.py

* add docstring

* modify docstring

Co-authored-by: Yezhen Cong <[email protected]>
Co-authored-by: THU17cyz <[email protected]>

* [Feature] Add roipooling cuda ops (open-mmlab#843)

* [Refactor] Main code modification for coordinate system refactor (open-mmlab#677)

* [Enhance] Add script for data update (open-mmlab#774)

* Fixed wrong config paths and fixed a bug in test

* Fixed metafile

* Coord sys refactor (main code)

* Update test_waymo_dataset.py

* Manually resolve conflict

* Removed unused lines and fixed imports

* remove coord2box and box2coord

* update dir_limit_offset

* Some minor improvements

* Removed some \s in comments

* Revert a change

* Change Box3DMode to Coord3DMode where points are converted

* Fix points_in_bbox function

* Fix Imvoxelnet config

* Revert adding a line

* Fix rotation bug when batch size is 0

* Keep sign of dir_scores as before

* Fix several comments

* Add a comment

* Fix docstring

* Add data update scripts

* Fix comments

* fix import

* add roipooling cuda ops

* add roi extractor

* add test_roi_extractor unittest

* Modify setup.py to install roipooling ops

* modify docstring

* remove enlarge bbox in roipoint pooling

* add_roipooling_ops

* modify docstring

Co-authored-by: Yezhen Cong <[email protected]>
Co-authored-by: THU17cyz <[email protected]>

* [Refactor] Refactor code structure and docstrings (open-mmlab#803)

* refactor points_in_boxes

* Merge same functions of three boxes

* More docstring fixes and unify x/y/z size

* Add "optional" and fix "Default"

* Add "optional" and fix "Default"

* Add "optional" and fix "Default"

* Add "optional" and fix "Default"

* Add "optional" and fix "Default"

* Remove None in function param type

* Fix unittest

* Add comments for NMS functions

* Merge methods of Points

* Add unittest

* Add optional and default value

* Fix box conversion and add unittest

* Fix comments

* Add unit test

* Indent

* Fix CI

* Remove useless \\

* Remove useless \\

* Remove useless \\

* Remove useless \\

* Remove useless \\

* Add unit test for box bev

* More unit tests and refine docstrings in box_np_ops

* Fix comment

* Add deprecation warning

* [Feature] PointXYZWHLRBBoxCoder (open-mmlab#856)

* support PointBasedBoxCoder

* fix unittest bug

* support unittest in gpu

* support unittest in gpu

* modified docstring

* add args

* add args

* [Enhance] Change Groupfree3D config (open-mmlab#855)

* All mods

* PointSample

* PointSample

* [Doc] Add tutorials/data_pipeline Chinese version (open-mmlab#827)

* [Doc] Add tutorials/data_pipeline Chinese version

* refine doc

* Use the absolute link

* Use the absolute link

Co-authored-by: Tai-Wang <[email protected]>

* [Doc] Add Chinese doc for `scannet_det.md` (open-mmlab#836)

* Part

* Complete

* Fix comments

* Fix comments

* [Doc] Add Chinese doc for `waymo_det.md` (open-mmlab#859)

* Add complete translation

* Refinements

* Fix comments

* Fix a minor typo

Co-authored-by: Tai-Wang <[email protected]>

* Remove 2D annotations on Lyft (open-mmlab#867)

* Add header for files (open-mmlab#869)

* Add header for files

* Add header for files

* Add header for files

* Add header for files

* [fix] fix typos (open-mmlab#872)

* Fix 3 unworking configs (open-mmlab#882)

* [Fix] Fix `index.rst` for Chinese docs (open-mmlab#873)

* Fix index.rst for zh docs

* Change switch language

* [Fix] Centerpoint head nested list transpose  (open-mmlab#879)

* FIX Transpose nested lists without Numpy

* Removed unused Numpy import

* [Enhance] Update PointFusion (open-mmlab#791)

* update point fusion

* remove LIDAR hardcode

* move get_proj_mat_by_coord_type to utils

* fix lint

* remove todo

* fix lint

* [Doc] Add nuscenes_det.md Chinese version (open-mmlab#854)

* add nus chinese doc

* add nuScenes Chinese doc

* fix typo

* fix typo

* fix typo

* fix typo

* fix typo

* [Fix] Fix RegNet pretrained weight loading (open-mmlab#889)

* Fix regnet pretrained weight loading

* Remove unused file

* Fix centerpoint tta (open-mmlab#892)

* [Enhance] Add benchmark regression script (open-mmlab#808)

* Initial commit

* [Feature] Support DGCNN (v1.0.0.dev0) (open-mmlab#896)

* support dgcnn

* support dgcnn

* support dgcnn

* support dgcnn

* support dgcnn

* support dgcnn

* support dgcnn

* support dgcnn

* support dgcnn

* support dgcnn

* fix typo

* fix typo

* fix typo

* del gf&fa registry (wo reuse pointnet module)

* fix typo

* add benchmark and add copyright header (for DGCNN only)

* fix typo

* fix typo

* fix typo

* fix typo

* fix typo

* support dgcnn

* Change cam rot_3d_in_axis (open-mmlab#906)

* [Doc] Add coord sys tutorial pic and change links to dev branch (open-mmlab#912)

* Modify link branch and add pic

* Fix pic

* Update v1.0.0rc0 changelog

* Remove v1.0.0.rc0 changelog

* Init v1.0.0.rc0 changelog

* Fix minor typos in the zh-CN index.rst

* Add master updates in changelog v1.0.0

* Update changelog_v1.0.md

* Update changelog_v1.0.md

* Update changelog_v1.0.md

* Adjust the order of logs

* Update the number of developers

* Add v1.0.0.rc0 changelog

* Delete changelog_v1.0.md

* Add RoIPointPool3d back

* Change openmmlab pre-commit hook rev

* Add links for compatibility doc

* Refine details

* Update README.md

* Update highlights

* Update README_zh-CN.md

* Update getting_started.md

* Update getting_started.md

* Update version.py

* Fix the released version name

* Fix version name

* Update version name

* Update version name

* Update version name

* Update version name

Co-authored-by: Yezhen Cong <[email protected]>
Co-authored-by: Xi Liu <[email protected]>
Co-authored-by: THU17cyz <[email protected]>
Co-authored-by: Wenhao Wu <[email protected]>
Co-authored-by: dingchang <[email protected]>
Co-authored-by: 谢恩泽 <[email protected]>
Co-authored-by: Robin Karlsson <[email protected]>
Co-authored-by: Danila Rukhovich <[email protected]>
Co-authored-by: ChaimZhu <[email protected]>

Co-authored-by: Wenhao Wu <[email protected]>
Co-authored-by: ChaimZhu <[email protected]>
Co-authored-by: Tai-Wang <[email protected]>
Co-authored-by: Double-Z <[email protected]>
Co-authored-by: zeyuzeng <[email protected]>
Co-authored-by: zeyu-hello <[email protected]>
Co-authored-by: maskjp <[email protected]>
Co-authored-by: peng <[email protected]>
Co-authored-by: Yezhen Cong <[email protected]>
Co-authored-by: Xi Liu <[email protected]>
Co-authored-by: THU17cyz <[email protected]>
Co-authored-by: dingchang <[email protected]>
Co-authored-by: 谢恩泽 <[email protected]>
Co-authored-by: Robin Karlsson <[email protected]>
@filaPro
Copy link
Contributor Author

filaPro commented Feb 23, 2022

Eventually I have broken this PR :( Should I close this one and open new?

And the lint is still broken not (only?) by this PR.

@ZCMax
Copy link
Collaborator

ZCMax commented Feb 23, 2022

no, the new lint problem is caused by merging master branch to dev branch, we will fix it right now. After that, you can merge dev branch again.

filaPro and others added 2 commits February 23, 2022 12:31
* Bump to v0.18.0 (open-mmlab#1148)

* Update README & getting_started & changelog & version.py

* resolve comments

* Update the required maximum version of mmcv-full

* Update changelog.md

* Update getting_started.md

* Add highlight in changelog.md

* update imvoxelnet citation (open-mmlab#1153)

* deprecate the support for "python setup.py test" (open-mmlab#1164)

* add OpenMMLab website and platform links (open-mmlab#1176)

* [Fix] Update regnet metafile (open-mmlab#1184)

* update regnet metafile

* Add Architechture in RegNet metafile

* fix axis=0 rotation in master branch (open-mmlab#1182)

* [Enhance] support semantic seg in Flip3D augmentation (open-mmlab#1181)

* support semantic seg in flip

* change box_dtype_3d to bbox3d_fields

* add point cloud annotation in doc (open-mmlab#1185)

* [Fix] Fix bug in non-distributed multi-gpu training/testing (open-mmlab#1197)

* Fix bug in non-distributed multi-gpu training/testing

* add deprecated warning to void BC-breaking

* Add missing explanation of cam_intrinsic in the nuScenes dataset doc (open-mmlab#1193)

* [Fix] Fix corner bug in different coordinates (open-mmlab#1212)

* fix corner bug in cam coord

* fix corner bugs in depth & lidar coord

* Bump to v0.18.1 (open-mmlab#1218)

* bump to v0.18.1

* fix comments

* update bazel version (open-mmlab#1223)

* [Fix] fix pointpillars bug on kitti in master branch (open-mmlab#1163)

* fix pointpillars bug on kitti in master branch

* replace with AlignedAnchorGenerator

* Update the installation of MMCV (open-mmlab#1226)

* [Fix] Fix a potential overflow bug when post_max_size is set too large in the circle_nms (open-mmlab#1225)

* [Fix] overflow bug

* [Fix] typo

Co-authored-by: zeyuzeng <[email protected]>
Co-authored-by: zeyu-hello <[email protected]>

* Fix PointRCNN bugs (open-mmlab#1224)

* fix bug to allow pointnet to train in fp16 (open-mmlab#1207)

* fix bug to allow pointnet to train in fp16

* remove unused import

* fix lint

* fix lint for gather_points_cuda.cu

Co-authored-by: peng <[email protected]>

* [Fix] Recheck import sorting (open-mmlab#1242)

* fix missed mmcv

* reinstall pre-commit and recheck

* fix inference_demo.ipynb bug (open-mmlab#1236)

* [Enhance] upgrade PointPillars performace on dev branch (open-mmlab#1166)

* upgrade PointPillars performace on dev branch

* update DynamicPillarFeatureNet

* fix comments

* change to AlignedAnchor3DRangeGenerator

* change to AlignedAnchor3DRangeGenerator

* fix

* replace with AlignedAnchorGenerator

* fix lint

* update using isort

* Bump to v1.0.0.rc0 (open-mmlab#928)

* [Refactor] Main code modification for coordinate system refactor (open-mmlab#677)

* [Enhance] Add script for data update (open-mmlab#774)

* Fixed wrong config paths and fixed a bug in test

* Fixed metafile

* Coord sys refactor (main code)

* Update test_waymo_dataset.py

* Manually resolve conflict

* Removed unused lines and fixed imports

* remove coord2box and box2coord

* update dir_limit_offset

* Some minor improvements

* Removed some \s in comments

* Revert a change

* Change Box3DMode to Coord3DMode where points are converted

* Fix points_in_bbox function

* Fix Imvoxelnet config

* Revert adding a line

* Fix rotation bug when batch size is 0

* Keep sign of dir_scores as before

* Fix several comments

* Add a comment

* Fix docstring

* Add data update scripts

* Fix comments

* fix import (open-mmlab#839)

* [Enhance]  refactor  iou_neg_piecewise_sampler.py (open-mmlab#842)

* [Refactor] Main code modification for coordinate system refactor (open-mmlab#677)

* [Enhance] Add script for data update (open-mmlab#774)

* Fixed wrong config paths and fixed a bug in test

* Fixed metafile

* Coord sys refactor (main code)

* Update test_waymo_dataset.py

* Manually resolve conflict

* Removed unused lines and fixed imports

* remove coord2box and box2coord

* update dir_limit_offset

* Some minor improvements

* Removed some \s in comments

* Revert a change

* Change Box3DMode to Coord3DMode where points are converted

* Fix points_in_bbox function

* Fix Imvoxelnet config

* Revert adding a line

* Fix rotation bug when batch size is 0

* Keep sign of dir_scores as before

* Fix several comments

* Add a comment

* Fix docstring

* Add data update scripts

* Fix comments

* fix import

* refactor iou_neg_piecewise_sampler.py

* add docstring

* modify docstring

Co-authored-by: Yezhen Cong <[email protected]>
Co-authored-by: THU17cyz <[email protected]>

* [Feature] Add roipooling cuda ops (open-mmlab#843)

* [Refactor] Main code modification for coordinate system refactor (open-mmlab#677)

* [Enhance] Add script for data update (open-mmlab#774)

* Fixed wrong config paths and fixed a bug in test

* Fixed metafile

* Coord sys refactor (main code)

* Update test_waymo_dataset.py

* Manually resolve conflict

* Removed unused lines and fixed imports

* remove coord2box and box2coord

* update dir_limit_offset

* Some minor improvements

* Removed some \s in comments

* Revert a change

* Change Box3DMode to Coord3DMode where points are converted

* Fix points_in_bbox function

* Fix Imvoxelnet config

* Revert adding a line

* Fix rotation bug when batch size is 0

* Keep sign of dir_scores as before

* Fix several comments

* Add a comment

* Fix docstring

* Add data update scripts

* Fix comments

* fix import

* add roipooling cuda ops

* add roi extractor

* add test_roi_extractor unittest

* Modify setup.py to install roipooling ops

* modify docstring

* remove enlarge bbox in roipoint pooling

* add_roipooling_ops

* modify docstring

Co-authored-by: Yezhen Cong <[email protected]>
Co-authored-by: THU17cyz <[email protected]>

* [Refactor] Refactor code structure and docstrings (open-mmlab#803)

* refactor points_in_boxes

* Merge same functions of three boxes

* More docstring fixes and unify x/y/z size

* Add "optional" and fix "Default"

* Add "optional" and fix "Default"

* Add "optional" and fix "Default"

* Add "optional" and fix "Default"

* Add "optional" and fix "Default"

* Remove None in function param type

* Fix unittest

* Add comments for NMS functions

* Merge methods of Points

* Add unittest

* Add optional and default value

* Fix box conversion and add unittest

* Fix comments

* Add unit test

* Indent

* Fix CI

* Remove useless \\

* Remove useless \\

* Remove useless \\

* Remove useless \\

* Remove useless \\

* Add unit test for box bev

* More unit tests and refine docstrings in box_np_ops

* Fix comment

* Add deprecation warning

* [Feature] PointXYZWHLRBBoxCoder (open-mmlab#856)

* support PointBasedBoxCoder

* fix unittest bug

* support unittest in gpu

* support unittest in gpu

* modified docstring

* add args

* add args

* [Enhance] Change Groupfree3D config (open-mmlab#855)

* All mods

* PointSample

* PointSample

* [Doc] Add tutorials/data_pipeline Chinese version (open-mmlab#827)

* [Doc] Add tutorials/data_pipeline Chinese version

* refine doc

* Use the absolute link

* Use the absolute link

Co-authored-by: Tai-Wang <[email protected]>

* [Doc] Add Chinese doc for `scannet_det.md` (open-mmlab#836)

* Part

* Complete

* Fix comments

* Fix comments

* [Doc] Add Chinese doc for `waymo_det.md` (open-mmlab#859)

* Add complete translation

* Refinements

* Fix comments

* Fix a minor typo

Co-authored-by: Tai-Wang <[email protected]>

* Remove 2D annotations on Lyft (open-mmlab#867)

* Add header for files (open-mmlab#869)

* Add header for files

* Add header for files

* Add header for files

* Add header for files

* [fix] fix typos (open-mmlab#872)

* Fix 3 unworking configs (open-mmlab#882)

* [Fix] Fix `index.rst` for Chinese docs (open-mmlab#873)

* Fix index.rst for zh docs

* Change switch language

* [Fix] Centerpoint head nested list transpose  (open-mmlab#879)

* FIX Transpose nested lists without Numpy

* Removed unused Numpy import

* [Enhance] Update PointFusion (open-mmlab#791)

* update point fusion

* remove LIDAR hardcode

* move get_proj_mat_by_coord_type to utils

* fix lint

* remove todo

* fix lint

* [Doc] Add nuscenes_det.md Chinese version (open-mmlab#854)

* add nus chinese doc

* add nuScenes Chinese doc

* fix typo

* fix typo

* fix typo

* fix typo

* fix typo

* [Fix] Fix RegNet pretrained weight loading (open-mmlab#889)

* Fix regnet pretrained weight loading

* Remove unused file

* Fix centerpoint tta (open-mmlab#892)

* [Enhance] Add benchmark regression script (open-mmlab#808)

* Initial commit

* [Feature] Support DGCNN (v1.0.0.dev0) (open-mmlab#896)

* support dgcnn

* support dgcnn

* support dgcnn

* support dgcnn

* support dgcnn

* support dgcnn

* support dgcnn

* support dgcnn

* support dgcnn

* support dgcnn

* fix typo

* fix typo

* fix typo

* del gf&fa registry (wo reuse pointnet module)

* fix typo

* add benchmark and add copyright header (for DGCNN only)

* fix typo

* fix typo

* fix typo

* fix typo

* fix typo

* support dgcnn

* Change cam rot_3d_in_axis (open-mmlab#906)

* [Doc] Add coord sys tutorial pic and change links to dev branch (open-mmlab#912)

* Modify link branch and add pic

* Fix pic

* Update v1.0.0rc0 changelog

* Remove v1.0.0.rc0 changelog

* Init v1.0.0.rc0 changelog

* Fix minor typos in the zh-CN index.rst

* Add master updates in changelog v1.0.0

* Update changelog_v1.0.md

* Update changelog_v1.0.md

* Update changelog_v1.0.md

* Adjust the order of logs

* Update the number of developers

* Add v1.0.0.rc0 changelog

* Delete changelog_v1.0.md

* Add RoIPointPool3d back

* Change openmmlab pre-commit hook rev

* Add links for compatibility doc

* Refine details

* Update README.md

* Update highlights

* Update README_zh-CN.md

* Update getting_started.md

* Update getting_started.md

* Update version.py

* Fix the released version name

* Fix version name

* Update version name

* Update version name

* Update version name

* Update version name

Co-authored-by: Yezhen Cong <[email protected]>
Co-authored-by: Xi Liu <[email protected]>
Co-authored-by: THU17cyz <[email protected]>
Co-authored-by: Wenhao Wu <[email protected]>
Co-authored-by: dingchang <[email protected]>
Co-authored-by: 谢恩泽 <[email protected]>
Co-authored-by: Robin Karlsson <[email protected]>
Co-authored-by: Danila Rukhovich <[email protected]>
Co-authored-by: ChaimZhu <[email protected]>

* fix ci in dev branch (open-mmlab#1264)

Co-authored-by: Wenhao Wu <[email protected]>
Co-authored-by: ChaimZhu <[email protected]>
Co-authored-by: Tai-Wang <[email protected]>
Co-authored-by: Double-Z <[email protected]>
Co-authored-by: zeyuzeng <[email protected]>
Co-authored-by: zeyu-hello <[email protected]>
Co-authored-by: maskjp <[email protected]>
Co-authored-by: peng <[email protected]>
Co-authored-by: Yezhen Cong <[email protected]>
Co-authored-by: Xi Liu <[email protected]>
Co-authored-by: THU17cyz <[email protected]>
Co-authored-by: dingchang <[email protected]>
Co-authored-by: 谢恩泽 <[email protected]>
Co-authored-by: Robin Karlsson <[email protected]>
@Tai-Wang
Copy link
Member

Tai-Wang commented Mar 1, 2022

Hi @filaPro sorry for the late reply. Could you please merge v1.0.0dev0? That should fix the lint and CI, and then we can merge this PR.

@filaPro
Copy link
Contributor Author

filaPro commented Mar 1, 2022

Don't quite understand why build is failed now... May be I can close this and make a new one to master?

@filaPro filaPro changed the base branch from v1.0.0.dev0 to master March 1, 2022 09:07
@filaPro
Copy link
Contributor Author

filaPro commented Mar 1, 2022

Lint is fine. Pytest is also fine on my side. Maybe smth wrong with mmcv version on your side?

@Tai-Wang
Copy link
Member

Tai-Wang commented Mar 1, 2022

Lint is fine. Pytest is also fine on my side. Maybe smth wrong with mmcv version on your side?

Yes, something related to spconv op is registered in mmcv now. Our op migration PR should fix this problem. Please don't worry.

@ZwwWayne ZwwWayne changed the base branch from master to dev March 2, 2022 09:35
@ZwwWayne ZwwWayne merged commit e3f0e8b into open-mmlab:dev Mar 9, 2022
@filaPro filaPro deleted the scannet_instance_dataset branch April 9, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instance segmentation on ScanNet
4 participants