Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Porting mmcv for hip #1022

Merged
merged 14 commits into from
Jul 9, 2021
Merged

[Feature] Porting mmcv for hip #1022

merged 14 commits into from
Jul 9, 2021

Conversation

XuanBaby
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

porting mmcv for rocm; need porting mmcv source code and hipidy-python

Modification

add ROCM module codes at setup.py

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #1022 (e82c5e0) into master (db580dd) will decrease coverage by 0.01%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1022      +/-   ##
==========================================
- Coverage   67.99%   67.97%   -0.02%     
==========================================
  Files         159      159              
  Lines       10426    10434       +8     
  Branches     1897     1899       +2     
==========================================
+ Hits         7089     7093       +4     
- Misses       2968     2970       +2     
- Partials      369      371       +2     
Flag Coverage Δ
unittests 67.97% <55.55%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/utils/parrots_wrapper.py 59.37% <55.55%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db580dd...e82c5e0. Read the comment docs.

@zhouzaida zhouzaida mentioned this pull request May 26, 2021
11 tasks
setup.py Show resolved Hide resolved
@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Jun 1, 2021

Actually, this PR LGTM. Do we have resources to test this PR on ARM machines?

@ZwwWayne ZwwWayne mentioned this pull request Jun 14, 2021
8 tasks
setup.py Show resolved Hide resolved
@zhouzaida zhouzaida mentioned this pull request Jun 21, 2021
13 tasks
@zhouzaida
Copy link
Collaborator

Actually, this PR LGTM. Do we have resources to test this PR on ARM machines?

yet, I am testing

@ZwwWayne ZwwWayne mentioned this pull request Jun 27, 2021
20 tasks
This was referenced Jun 29, 2021
@zhouzaida zhouzaida changed the title porting mmcv for hip [Feature] Porting mmcv for hip Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants