-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Porting mmcv for hip #1022
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1022 +/- ##
==========================================
- Coverage 67.99% 67.97% -0.02%
==========================================
Files 159 159
Lines 10426 10434 +8
Branches 1897 1899 +2
==========================================
+ Hits 7089 7093 +4
- Misses 2968 2970 +2
- Partials 369 371 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Actually, this PR LGTM. Do we have resources to test this PR on ARM machines? |
yet, I am testing |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
porting mmcv for rocm; need porting mmcv source code and hipidy-python
Modification
add ROCM module codes at setup.py
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist