fix: enable linter: maintidx #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues fixed: - Fix issues with auto fix (`--fix`). - Rename `this` receivers. - Fix language issues, most of the duplicated words like "the the". - Removed unnecessary type conversion. - Reduced complexity of the `_apply` function by extracting some parts into a separate function. - Reduced complexity of the `push` function by extracting some parts into a separate function. References: - #91 Closes #91
|
Please review the extracted functions carefully, I tried to be careful, but it does not mean I did not miss something. These functions have no tests, so I couldn't verify everything with tests. |
mandelsoft
requested changes
Nov 9, 2022
yitsushi
force-pushed
the
91-fix-maintidx
branch
from
2d5872a to
dad5362
Compare
mandelsoft
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues fixed:
--fix).thisreceivers._applyfunction by extracting some parts into a separate function.pushfunction by extracting some parts into a separate function.References:
Closes #91