Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable linter: maintidx #91

Closed
yitsushi opened this issue Sep 1, 2022 · 0 comments · Fixed by #177
Closed

enable linter: maintidx #91

yitsushi opened this issue Sep 1, 2022 · 0 comments · Fixed by #177
Assignees
@yitsushi

Comments

@yitsushi
Copy link
Contributor

yitsushi commented Sep 1, 2022

maintidx measures the maintainability index of each function.

Default is 20, which is too low I think, but we have some extreme functions, for example:

name: push, Cyclomatic Complexity: 35
name: apply, Cyclomatic Complexity: 51
@yitsushi yitsushi mentioned this issue Sep 1, 2022
Closed
@yitsushi yitsushi self-assigned this Nov 8, 2022
yitsushi added a commit that referenced this issue Nov 8, 2022
@yitsushi
fix: enable linter: maintidx
bffb150 
Issues fixed:
- Fix issues with auto fix (`--fix`).
- Rename `this` receivers.
- Fix language issues, most of the duplicated words like "the the".
- Removed unnecessary type conversion.
- Reduced complexity of the `_apply` function by extracting some parts
  into a separate function.
- Reduced complexity of the `push` function by extracting some parts
  into a separate function.

References:
- #91

Closes #91
@yitsushi yitsushi mentioned this issue Nov 8, 2022
Merged
mandelsoft pushed a commit that referenced this issue Nov 10, 2022
@yitsushi
fix: enable linter: maintidx (#177)
8f1c6dd 
* fix: enable linter: maintidx

Issues fixed:
- Fix issues with auto fix (`--fix`).
- Rename `this` receivers.
- Fix language issues, most of the duplicated words like "the the".
- Removed unnecessary type conversion.
- Reduced complexity of the `_apply` function by extracting some parts
  into a separate function.
- Reduced complexity of the `push` function by extracting some parts
  into a separate function.

References:
- #91

Closes #91

* address pr comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yitsushi yitsushi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: enable linter: maintidx open-component-model/ocm
1 participant
@yitsushi