Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: also create a branch based on the tag to avoid dangling commits #1098

Merged
merged 4 commits into from
Nov 18, 2024
Merged

chore: also create a branch based on the tag to avoid dangling commits #1098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
96b682b
chore: also create a tag to avoid dangling commits
jakobmoellerdev Nov 18, 2024
bf30563
chore: only run release drafter on non-patch
jakobmoellerdev Nov 18, 2024
ac5c922
chore: only run release drafter on non-patch
jakobmoellerdev Nov 18, 2024
569d529
Merge branch 'main' into chore/also-create-branch-not-just-tag
jakobmoellerdev Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/release-drafter.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ name: Release Drafter
on:
push:
branches:
- releases/*
# we only want to draft release notes for the base version,
# e.g. for releases/v0.18, we draft v0.18.0 for all RCs
# this means that we explicitly don't want to draft release notes for releases/v0.18.0 or releases/v0.18.1
- 'releases/v[0-9]+.[0-9]+'
jakobmoellerdev marked this conversation as resolved.
Show resolved Hide resolved

permissions:
contents: read
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,8 @@ jobs:
git commit -m "Release $RELEASE_VERSION"
msg="Release ${{ env.RELEASE_VERSION }}"
git tag --annotate --message "${msg}" ${{ env.RELEASE_VERSION }}
git push origin ${{ env.RELEASE_VERSION }}
# push both the tag as well as a release branch with that tag.
git push origin releases/${{ env.RELEASE_VERSION }} ${{ env.RELEASE_VERSION }}
Skarlso marked this conversation as resolved.
Show resolved Hide resolved

- name: Create GPG Token file from Secret
run: |
Expand Down
Loading