chore: also create a branch based on the tag to avoid dangling commits #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently our tagged releases do not have branch accomodating them, leading to dangling commits. This fixes this by also creating an appropriate release branch. This might introduce issues with things like the release drafter though, so this is likely only the first line of commits for this
Skarlso
approved these changes
Nov 18, 2024
Skarlso
reviewed
Nov 18, 2024
Skarlso
requested changes
Nov 18, 2024
|
The release note is only pushed to whichever branch the release is run on. This is independant of this change though |
Skarlso
previously approved these changes
Nov 18, 2024
jakobmoellerdev
changed the title
Skarlso
reviewed
Nov 18, 2024
Skarlso
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
currently our tagged releases do not have branch accomodating them, leading to dangling commits. (see https://github.com/open-component-model/ocm/tree/v0.18.0-rc.1 for an example)
This fixes this by also creating an appropriate release branch.
This might introduce issues with things like the release drafter though, so this is likely only the first line of commits for this.
Which issue(s) this PR fixes
fix #1099