chore: release fallout corrections #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runs make generate because it was only run on the release branch. adds check as mandatory dep of release to make sure the tag-check inside is not rgiacing against release
hilmarf
previously approved these changes
Oct 29, 2024
hilmarf
approved these changes
Oct 29, 2024
hilmarf
added
component/github-actions
mandelsoft
pushed a commit
that referenced
this pull request
Oct 31, 2024
runs make generate because it was only run on the release branch. adds check as mandatory dep of release to make sure the tag-check inside is not rgiacing against release. adds necessary build steps for tools needed in make generate. <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. -->
mandelsoft
pushed a commit
that referenced
this pull request
Oct 31, 2024
runs make generate because it was only run on the release branch. adds check as mandatory dep of release to make sure the tag-check inside is not rgiacing against release. adds necessary build steps for tools needed in make generate. <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. -->
mandelsoft
pushed a commit
that referenced
this pull request
Oct 31, 2024
runs make generate because it was only run on the release branch. adds check as mandatory dep of release to make sure the tag-check inside is not rgiacing against release. adds necessary build steps for tools needed in make generate. <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runs make generate because it was only run on the release branch. adds check as mandatory dep of release to make sure the tag-check inside is not rgiacing against release. adds necessary build steps for tools needed in make generate.
What this PR does / why we need it
Which issue(s) this PR fixes