Skip to content

Commit

Permalink
chore: release fallout corrections (#1023)
Browse files Browse the repository at this point in the history
runs make generate because it was only run on the release branch. adds
check as mandatory dep of release to make sure the tag-check inside is
not rgiacing against release. adds necessary build steps for tools
needed in make generate.

<!-- markdownlint-disable MD041 -->
#### What this PR does / why we need it

#### Which issue(s) this PR fixes
<!--
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
  • Loading branch information
jakobmoellerdev authored and mandelsoft committed Oct 31, 2024
1 parent 11abeaa commit e8be8e7
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,10 @@ jobs:
pull-requests: read

release:
# needs:
# - lint-and-test
# - components
needs:
# run check before actual release to make sure we succeed
# they will be skipped from the needs check
- check
name: Release Build
runs-on: large_runner
permissions:
Expand Down Expand Up @@ -283,7 +284,7 @@ jobs:
v="$(go run ./api/version/generate bump-version)"
echo "$v" > VERSION
# Trigger a bump of any potential files that depend on a new version
make generate
make -f hack/Makefile mdref && make -f hack/Makefile go-bindata && make generate
git add --all
git commit -m "Update version to $v"
git push origin ${GITHUB_REF#refs/heads/}
Expand Down

0 comments on commit e8be8e7

Please sign in to comment.