feat(dx): add tooling to fix formatting issues #102
Conversation
|
@yitsushi Thank you for your contribution. |
pkg/contexts/ocm/compdesc/versions/ocm.gardener.cloud/v3alpha1/jsonscheme/bindata.go
Outdated
Show resolved
Hide resolved
pkg/utils/utils_suite_test.go
Outdated
| // Copyright 2022 SAP SE or an SAP affiliate company. All rights reserved. This file is licensed under the Apache Software License, v. 2 except as noted otherwise in the LICENSE file | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // |
There was a problem hiding this comment.
why is the indentation changed? Do we have the empty comment line in-between?
There was a problem hiding this comment.
I have no idea, I just run the auto formatter
There was a problem hiding this comment.
Interesting it's not gci, it's the goimports.
|
Sorry, I think some of the moved external imports are moved to the test imports, because there was no section for external imports other than the one with the ginkgo imports. Then I understand why it is done. But maybe we could separate those manually. |
yitsushi
force-pushed
the
dx-makefile
branch
from
0c4761a to
f32ee57
Compare
|
@mandelsoft : I tried to figure out how can I add some extra custom logic, but I couldn't. In theory I should be able to do that, but I found close to no documentation about it. I found docs only about how to change the order of the predefined groups, which is I think useless. |
|
@yitsushi , You told me some days ago, that it accepts it, if it is grouped manually, this is completely fine, we just have to it manually, once, |
Changes under
cmds/andpkg/are coming frommake format.