Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix units of incorrect caption timestamps #907

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Fix units of incorrect caption timestamps #907

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1c08fd
Fix units of incorrect caption timestamps
mhbuehler Nov 15, 2024
742eeef
Merge branch 'main' into melanie/timestamp_fix
mhbuehler Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion comps/dataprep/multimodal/redis/langchain/multimodal_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def extract_frames_and_generate_captions(
idx += 1

mid_time = vidcap.get(cv2.CAP_PROP_POS_MSEC)
mid_time_ms = mid_time * 1000
mid_time_ms = mid_time # Already in ms

frame_no = curr_frame
frame = cv2.cvtColor(frame, cv2.COLOR_BGR2RGB)
Expand Down
Loading