Fix units of incorrect caption timestamps #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Melanie Buehler <[email protected]>
kding1
approved these changes
Nov 15, 2024
cameronmorin
pushed a commit
to opea-aws-proserve/GenAIComps
that referenced
this pull request
Nov 21, 2024
Signed-off-by: Melanie Buehler <[email protected]> Signed-off-by: Cameron Morin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in caption generation for videos. The timestamp was unnecessarily multiplied by 1000, which when passed to the MultimodalQnA UI was causing the video clip to not be displayed.
Issues
MultimodalQnA Images & Video Enhancements RFC
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
N/A
Tests
N/A