vLLM support for FAQGen #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sgurunat <[email protected]>
…rt for vllm endpoints Signed-off-by: sgurunat <[email protected]>
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
amberjain1
reviewed
Nov 11, 2024
comps/llms/faq-generation/vllm/langchain/docker_compose_llm.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: sgurunat <[email protected]>
for more information, see https://pre-commit.ci
|
Please update comps/llms/faq-generation/vllm/langchain/Dockerfile to .github/workflows/docker/compose/llms-compose-cd.yaml. The yaml is used for release images build. |
…kflows Signed-off-by: sgurunat <[email protected]>
|
@lvliang-intel - I don't see the llm-compose-cd.yaml file. I did Update Branch and looks like the latest changes in main doesn't have this file. |
Signed-off-by: sgurunat <[email protected]>
Signed-off-by: sgurunat <[email protected]>
|
@chensuyue @lvliang-intel Updated the git workflows to include vllm faqgen build in llm-compose.yaml file |
chensuyue
approved these changes
Nov 13, 2024
|
at next release, we need consider how to merge such instances with others to avoid code duplication. |
ftian1
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added langchain vLLM support for Faq-Generation. Added new folder called vllm under faq-generation and have maintained the same file structure similar to tgi. Dockerfile, compose yaml and README contains details about how to build and use FaQ with vLLM.
This also contains changes related to authentication support for remote vLLM endpoints in llm.py file.
Since model is mandatory parameter for vLLM updated the FaqGenGateway to include the new parameter called "model" in Mega service gateway.py file
Issues
N/A
Type of change
Dependencies
N/A