Fixed Orchestrator schedule method #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sanket Nayak <[email protected]>
sunnstix
force-pushed
the
orchestrator-llmparam-fix
branch
from
c9a3625 to
21293a6
Compare
|
Failures are caused by dependency issues - see #397 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
lvliang-intel
approved these changes
Aug 7, 2024
Spycsh
approved these changes
Aug 7, 2024
sharanshirodkar7
pushed a commit
to predictionguard/pg-GenAIComps
that referenced
this pull request
Aug 7, 2024
Signed-off-by: Sanket Nayak <[email protected]> Co-authored-by: Sanket Nayak <[email protected]> Co-authored-by: lvliang-intel <[email protected]> Signed-off-by: sharanshirodkar7 <[email protected]>
yogeshmpandey
pushed a commit
to yogeshmpandey/GenAIComps
that referenced
this pull request
Aug 9, 2024
Signed-off-by: Sanket Nayak <[email protected]> Co-authored-by: Sanket Nayak <[email protected]> Co-authored-by: lvliang-intel <[email protected]>
BaoHuiling
pushed a commit
to siddhivelankar23/GenAIComps
that referenced
this pull request
Aug 15, 2024
Signed-off-by: Sanket Nayak <[email protected]> Co-authored-by: Sanket Nayak <[email protected]> Co-authored-by: lvliang-intel <[email protected]> Signed-off-by: BaoHuiling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed edge condition for
comps.ServiceOrchestratorwhere LLMParams provided in the Megaservice Gateway are ignored if a node is an independent node.Independent nodes use the following snippet, which does not pass in the llm_parameters variable:
GenAIComps/comps/cores/mega/orchestrator.py
Lines 49 to 52 in de27e6b
All consequent dependent nodes use this snippet, which does pass in the llm_parameters variable:
GenAIComps/comps/cores/mega/orchestrator.py
Lines 79 to 82 in de27e6b
Issues
#402
Type of change
Dependencies
N/A
Tests
Tested on modified version of
tests/test_workflow_chatqna.shusing DocSum Gateway. Bug only affects megaservices with an LLM as an independent node.