Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickfix: Replace fastapi dep with fastapi[standard] #397

Closed
wants to merge 2 commits into from

Conversation

sunnstix
Copy link
Contributor

@sunnstix sunnstix commented Aug 2, 2024

Description

fastapi is now an alias for fastapi-slim as per the release of version 1.112.

Before this, fastapi would include the standard dependencies, with Uvicorn and the fastapi-cli, etc.
And fastapi-slim would not include those standard dependencies.
Now fastapi doesn't include those standard dependencies unless you install with pip install "fastapi[standard]".

Issues

#395

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Dependencies

N/A

Tests

N/A

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@chensuyue
Copy link
Collaborator

Please fix the conflict.

@chensuyue chensuyue added this to the v0.9 milestone Aug 17, 2024
@chensuyue
Copy link
Collaborator

@sunnstix please fix the conflict.

@chensuyue
Copy link
Collaborator

Please fix the conflict, so I can merge this PR. @sunnstix

@sunnstix
Copy link
Contributor Author

@chensuyue I would argue that this change no longer needs to be implemented with the new inclusion of dependencies such as uvicorn independently. The standard fastapi package introduces dependencies outside of just uvicorn that are unnecessary and if we can manually install all the needed dependencies while using the lightweight version of fastapi, I think that is better. Feel free to close this PR if you agree.

@chensuyue chensuyue closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants