Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

desktop: re-add support for riseupvpn #2576

Open
bassosimone opened this issue Oct 18, 2023 · 3 comments
Open

desktop: re-add support for riseupvpn #2576

bassosimone opened this issue Oct 18, 2023 · 3 comments
Assignees
@majakomel

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Oct 18, 2023 •
edited
Loading

We re-added riseupvpn in ooni/probe-cli in 3.19.0-alpha.3. Specifically, riseupvpn is a default-disabled experimental experiment now. This means that we can control whether it could run through the check-in API.

What happens if we force enable and run it on desktop? Let's try to fix bugs or revert adding riseupvpn if it's too hard.
@bassosimone bassosimone added the releaseBlocker This issue blocks releasing label Oct 18, 2023
@bassosimone bassosimone self-assigned this Oct 18, 2023
bassosimone added a commit to ooni/probe-desktop that referenced this issue Oct 18, 2023
@bassosimone
fix: make riseupvpn an experimental nettest
c837077 
Reference issue: ooni/probe#2576

Specifically:

1. make sure the nettest runs (see issue to see how);

2. make sure it runs as experimental (i.e., gray);

3. make sure the results look like experimental results.
bassosimone added a commit to ooni/probe-desktop that referenced this issue Oct 18, 2023
@bassosimone
chore: use ooni/[email protected]
c29c522 
This is the latest alpha release as of this writing and contains
the necessary code to run riseupvpn as a default-disable experimental
nettest. As documented by ooni/probe#2576,
this release also has an issue when running that we'll fix on the
probe-cli side as soon as possible.
@bassosimone
Copy link
Contributor Author

So, first of all, how to test RiseupVPN in probe-desktop?

One needs to use the latest 3.19.0-alpha release (3.19.0-alpha.4 as of this writing) or one could alternatively use the ./MONOREPO scripts to build ooniprobe on the fly and use it with probe-desktop. In the latter case, using the master branch is fine, because master is currently ~equal to the release/3.19 branch (but it may change ~soon).

Then, one needs to run websites once, to make sure there is a check-in flags cache.

Then, edit ./ooni_home/engine/checkinflags.state (i.e., the state created by check-in) and make sure it contains

{
  "Expire": "2023-10-19T16:53:42.096488+02:00",
  "Flags": {
    "riseupvpn_enabled": true
  }
}

The Expire will depend on your last invocation of websites. What matters is adding the proper flags.

Once you've done this, you're all set an can run experimental in desktop to also run riseupvpn.

@bassosimone bassosimone mentioned this issue Oct 18, 2023
Merged
@bassosimone
Copy link
Contributor Author

bassosimone commented Oct 18, 2023 •
edited
Loading

While doing QA, we identified the following issues:

  1. because echecheck is also disabled, we see a warning while running experimental, which visually looks like this:
Screenshot 2023-10-18 at 17 01 42

This will be fixed by tagging a subsequent alpha release of ooni/probe-cli. I'll explain why the change is needed directly in the commit message that fixes this issue.

  1. the RiseupVPN result appears in the right place but has styling that depends on its former "circumvention" status:
Screenshot 2023-10-18 at 17 02 39 Screenshot 2023-10-18 at 17 02 59

We opened ooni/probe-desktop#332 to fix this second issue.

bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 18, 2023
@bassosimone
fix(nettests): failing to start a nettest is a warning
e8e918f 
Emitting an error causes ooni/probe-desktop to try to generate
a warning window that (1) is a bit unpleasant to visually see and
(2) more importantly is not proper to show, given that we have
default-disabled experiments right now.

See ooni/probe#2576 for extra information.
@bassosimone bassosimone mentioned this issue Oct 18, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 18, 2023
@bassosimone
fix(nettests): failing to start a nettest is a warning (#1373)
5c93d4c 
Emitting an error causes ooni/probe-desktop to try to generate a warning
window that (1) is a bit unpleasant to visually see and (2) more
importantly is not proper to show, given that we have default-disabled
experiments right now.

Also, in my book, we should emit warning if we continue running and
errors when we stop. (Maybe it's not the best book considering that
assumes that all errors are fatal; in any case, try to be consistent
with this convention.)

See ooni/probe#2576 for extra information.
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 18, 2023
@bassosimone
fix(nettests): failing to start a nettest is a warning
7c4e537 
This diff backports #1373 to the release/3.19 branch.

Emitting an error causes ooni/probe-desktop to try to generate a warning
window that (1) is a bit unpleasant to visually see and (2) more
importantly is not proper to show, given that we have default-disabled
experiments right now.

Also, in my book, we should emit warning if we continue running and
errors when we stop. (Maybe it's not the best book considering that
assumes that all errors are fatal; in any case, try to be consistent
with this convention.)

See ooni/probe#2576 for extra information.
@bassosimone
Copy link
Contributor Author

I am going to transfer the ownership of this issue to @majakomel.

@bassosimone bassosimone assigned majakomel and unassigned bassosimone Oct 20, 2023
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
fix(nettests): failing to start a nettest is a warning (ooni#1373)
6485c8b 
Emitting an error causes ooni/probe-desktop to try to generate a warning
window that (1) is a bit unpleasant to visually see and (2) more
importantly is not proper to show, given that we have default-disabled
experiments right now.

Also, in my book, we should emit warning if we continue running and
errors when we stop. (Maybe it's not the best book considering that
assumes that all errors are fatal; in any case, try to be consistent
with this convention.)

See ooni/probe#2576 for extra information.
@bassosimone bassosimone removed the releaseBlocker This issue blocks releasing label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@majakomel majakomel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bassosimone @majakomel