fix(nettests): failing to start a nettest is a warning #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emitting an error causes ooni/probe-desktop to try to generate a warning window that (1) is a bit unpleasant to visually see and (2) more importantly is not proper to show, given that we have default-disabled experiments right now. See ooni/probe#2576 for extra information.
bassosimone
commented
Oct 18, 2023
bassosimone
added a commit
that referenced
this pull request
Oct 18, 2023
This diff backports #1373 to the release/3.19 branch. Emitting an error causes ooni/probe-desktop to try to generate a warning window that (1) is a bit unpleasant to visually see and (2) more importantly is not proper to show, given that we have default-disabled experiments right now. Also, in my book, we should emit warning if we continue running and errors when we stop. (Maybe it's not the best book considering that assumes that all errors are fatal; in any case, try to be consistent with this convention.) See ooni/probe#2576 for extra information.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
Emitting an error causes ooni/probe-desktop to try to generate a warning window that (1) is a bit unpleasant to visually see and (2) more importantly is not proper to show, given that we have default-disabled experiments right now. Also, in my book, we should emit warning if we continue running and errors when we stop. (Maybe it's not the best book considering that assumes that all errors are fatal; in any case, try to be consistent with this convention.) See ooni/probe#2576 for extra information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emitting an error causes ooni/probe-desktop to try to generate a warning window that (1) is a bit unpleasant to visually see and (2) more importantly is not proper to show, given that we have default-disabled experiments right now.
Also, in my book, we should emit warning if we continue running and errors when we stop. (Maybe it's not the best book considering that assumes that all errors are fatal; in any case, try to be consistent with this convention.)
See ooni/probe#2576 for extra information.