-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: upgrade to go1.18.5 #2223
Labels
Comments
bassosimone
added
priority/high
technical task
technical tasks e.g. deployment
ooni/probe-engine
labels
Aug 22, 2022
bassosimone
added a commit
to ooni/oohttp
that referenced
this issue
Aug 22, 2022
Merge go1.18.5 into the stable v0.2.x train Part of ooni/probe#2223
bassosimone
added a commit
to ooni/oohttp
that referenced
this issue
Aug 22, 2022
I forgot to change the entry before. Spotted while working on ooni/probe#2223.
bassosimone
added a commit
to ooni/oohttp
that referenced
this issue
Aug 22, 2022
bassosimone
added a commit
to ooni/oohttp
that referenced
this issue
Aug 22, 2022
Part of ooni/probe#2223 I'm reading the diff with respect to main and applying changes that should also be part of the stable branch.
bassosimone
added a commit
to ooni/probe-cli
that referenced
this issue
Aug 22, 2022
This diff pins OONI to use go1.18.5 and oohttp and oocrypto at go1.18.5 as the version of go with which we build releases. The same codebase also works with go1.19 although this configuration cannot include Psiphon (see ooni/probe#2222). Closes ooni/probe#2223.
bassosimone
added a commit
to ooni/oocrypto
that referenced
this issue
Aug 22, 2022
This diff backports code to correctly handle darwin/arm64 from `main` (see #7). While there, this diff aims at reducing unnecessary differences with the main branch, by removing code we also removed in there. The reference issues are: 1. ooni/probe#2122 2. ooni/probe#2223
bassosimone
added a commit
to ooni/oocrypto
that referenced
this issue
Aug 22, 2022
This diff backports code to correctly handle darwin/arm64 from `main` (see #7). While there, this diff aims at reducing unnecessary differences with the main branch, by removing code we also removed in there. The reference issues are: 1. ooni/probe#2122 2. ooni/probe#2223
bassosimone
added a commit
to ooni/probe-cli
that referenced
this issue
Aug 22, 2022
* chore: use {go,oohttp,oocrypto} v1.18.5 This diff pins OONI to use go1.18.5 and oohttp and oocrypto at go1.18.5 as the version of go with which we build releases. The same codebase also works with go1.19 although this configuration cannot include Psiphon (see ooni/probe#2222). Closes ooni/probe#2223. * fix: use [email protected] This ensures we keep ooni/probe#2122 fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Because we cannot upgrade directly to go1.19 (issue #2211) because of issue #2222, let's update to go1.18.5. This entails ensuring that the oohttp and oocrypto versions we're using are 100% compatible with go1.18.5 (they're currently using go1.19, unfortunately). Here's what changed between go1.18.3 and go1.18.5 in
src/net/http
:And here's what changed in
src/crypto
:That is, nothing actually changes.
From this, it stems that we should only update
oohttp
(which we did in ooni/oohttp#31) and we should not change anything inoocrypto
. Yet, we may need some extra changes to support go1.19 as well.The text was updated successfully, but these errors were encountered: