Skip to content

Commit

Permalink
chore: sync README with the main branch
Browse files Browse the repository at this point in the history
  • Loading branch information
bassosimone committed Aug 22, 2022
1 parent 624798f commit 1be0ee4
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -237,9 +237,11 @@ git merge golang-http-upstream
- [ ] solve the very-likely merge conflicts and ensure [the original spirit of the
patches](#patches) still hold;

- [ ] make sure the codebase does not assume `*tls.Conn` *anywhere* (`git grep '\*tls\.Conn'`);
- [ ] make sure the codebase does not assume `*tls.Conn` *anywhere* (`git grep -n '\*tls\.Conn'`)
and otherwise replace `*tls.Conn` with `TLSConn`;

- [ ] make sure the codebase does not call `tls.Client` *anywhere* (`git grep '\*tls\.Client'`);
- [ ] make sure the codebase does not call `tls.Client` *anywhere* (`git grep -n 'tls\.Client'`)
and otherwise replace `tls.Client` with `TLSClientFactory`;

- [ ] ensure `go build -v ./...` still works;

Expand All @@ -248,6 +250,8 @@ patches](#patches) still hold;
- [ ] ensure [stdlibwrapper.go](stdlibwrapper.go) copies all
the `Request` and `Response` fields;

- [ ] run `go get -u -v ./... && go mod tidy`;

- [ ] commit the changes and push `merged-main` to gitub;

- [ ] open a PR and merge it *using a merge commit*;
Expand Down

0 comments on commit 1be0ee4

Please sign in to comment.