Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering the cleaner page on Ruby 3 #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sharang-d
Copy link

@sharang-d sharang-d commented Sep 30, 2021

What?

Makes the cleaner page work on Ruby 3.

Screenshots

Before:
135488904-0bc00d45-57dc-4ac2-8ba9-77c22bad037b

After:
Resque 2021-09-30 21-26-37

Notes

This PR is similar to resque/resque-scheduler@e7e2531.

@ono I'm aware of #47 but hoping we can get this in because it is tiny and makes the gem work with Ruby 3 :)

@NobodysNightmare
Copy link

I can confirm that this fixes the issue. Not sure if @ono still maintains this project, but it would be nice to see this fixed upstream.

Let me know if I can help in any meaningful way.

@josh-m-sharpe
Copy link

fixed this in https://rubygems.org/gems/resque-cleanerer

@hostaway-greg
Copy link

hostaway-greg commented Dec 26, 2023

fixed this in https://rubygems.org/gems/resque-cleanerer

How do I use that? I have installed that gem and replaced it in my config file but I am getting this:

sudo gem install resque-cleanerer
Successfully installed resque-cleanerer-0.5.0
Parsing documentation for resque-cleanerer-0.5.0
Done installing documentation for resque-cleanerer after 0 seconds
1 gem installed
resque-web -p 1335 config/resque-web.rb
<internal:/usr/lib/ruby/vendor_ruby/rubygems/core_ext/kernel_require.rb>:85:in `require': cannot load such file -- resque-cleanerer (LoadError)
        from <internal:/usr/lib/ruby/vendor_ruby/rubygems/core_ext/kernel_require.rb>:85:in `require'
        from (eval):1:in `load_config_file'
        from /var/lib/gems/3.0.0/gems/resque-2.6.0/lib/resque/web_runner.rb:252:in `module_eval'
        from /var/lib/gems/3.0.0/gems/resque-2.6.0/lib/resque/web_runner.rb:252:in `load_config_file'
        from /var/lib/gems/3.0.0/gems/resque-2.6.0/lib/resque/web_runner.rb:102:in `before_run'
        from /var/lib/gems/3.0.0/gems/resque-2.6.0/lib/resque/web_runner.rb:47:in `initialize'
        from /var/lib/gems/3.0.0/gems/resque-2.6.0/bin/resque-web:15:in `new'
        from /var/lib/gems/3.0.0/gems/resque-2.6.0/bin/resque-web:15:in `<top (required)>'
        from /usr/local/bin/resque-web:25:in `load'
        from /usr/local/bin/resque-web:25:in `<main>'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants