Replace deprecated URI.encode with URI.encode_www_form_component #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on the review env it LGTM. |
andrewmarkle
approved these changes
Nov 16, 2022
jscharf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to ono#53
We need to update deprecated code in this repository as part of work to upgrade our application to Ruby 3.
URI.encodeis obsolete and needs to be replaced.I replaced it with
encode_www_form_componentto encode the query string instead.You can read more about this on the page for the Rubocop lint rule about it https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/UriEscapeUnescape