Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable Cadence #3498

Closed
wants to merge 25 commits into from
Closed

Stable Cadence #3498

wants to merge 25 commits into from

Conversation

turbolent
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit 883be2d

The command (for i in {1..10}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-24.37s ± 3%4.11s ± 0%~(p=0.182 n=10+1)
 
alloc/opdelta
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-21.15GB ± 1%1.09GB ± 0%~(p=0.182 n=10+1)
 
allocs/opdelta
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-217.2M ± 0%15.8M ± 0%~(p=0.182 n=10+1)
 
us/txdelta
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-22.13k ± 3%2.01k ± 0%~(p=0.182 n=10+1)
 

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

Merging #3498 (652172d) into master (883be2d) will decrease coverage by 1.42%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3498      +/-   ##
==========================================
- Coverage   55.26%   53.84%   -1.43%     
==========================================
  Files         755      606     -149     
  Lines       69192    52134   -17058     
==========================================
- Hits        38241    28070   -10171     
+ Misses      27809    21754    -6055     
+ Partials     3142     2310     -832     
Flag Coverage Δ
unittests 53.84% <100.00%> (-1.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fvm/environment/account_key_updater.go 19.91% <ø> (+0.22%) ⬆️
fvm/environment/meter.go 78.43% <ø> (ø)
fvm/meter/meter.go 91.50% <ø> (ø)
utils/unittest/execution_state.go 58.33% <ø> (ø)
fvm/environment/facade_env.go 99.52% <100.00%> (+<0.01%) ⬆️
engine/common/splitter/network/network.go
engine/execution/rpc/engine.go
engine/consensus/matching/core.go
...e/execution/computation/computer/uploader/model.go
...ngine/consensus/approvals/aggregated_signatures.go
... and 146 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@SupunS
Copy link
Member

SupunS commented Aug 11, 2023

Closing this PR as this is outdated now.
A new PR is available for updating to latest stable-cadence version: #4567

@SupunS SupunS closed this Aug 11, 2023
@turbolent turbolent deleted the feature/stable-cadence branch August 14, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants