-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Downstream deps for stable-cadence branch #2084
Comments
Currently the update of flow-go is blocked by an update of the Flow core contracts to Stable Cadence, tracked in #1820. Pinged here: |
Core contracts are updated: onflow/flow-core-contracts#319 Updated flow-go to the updated core contracts and updated the tests in: onflow/flow-go#3498 |
Next blocker is the NFT standard contract. It uses |
@sideninja The dependencies up to and including the Emulator are now updated:
|
Nice. Should we tag them and do a release with the secure cadence tag? |
Yes, good point. I'll tag them |
We were using a tag called |
Tagged, updated the comment above |
Thank you. Should I release a CLI with these versions? By when should a release be ready? |
Yes, that would be great, thanks! We also need to update the Cadence tools (e.g. test framework, language server). I can take care of this too if you want. As for timing, there's no rush, we just like to get a preview release out as soon as it's ready, so that developers can start updating their contracts early and give feedback on the changes. |
@sideninja Everything is now updated to preview 4 in onflow/flow-cli@master...release/stable-cadence, so it would be nice to get a release for that out |
Greg successfully built a CLI binary with preview 4. I tested it and found issues relating to I'll tag preview 5 and do another round of updates, which will luckily from now on just be version bumps. |
Tagged and updated everything to preview 5: onflow/flow-cli@master...release/stable-cadence. Ping Gregor to build and publish another CLI release of that branch |
CLI preview release tagged: https://github.com/onflow/flow-cli/releases/tag/v0.41.3-stable-cadence-5 Going to wait for feedback. If deemed OK, will announce as first preview release for Stable Cadence and close issue. |
Issue To Be Solved
We would like to have a CLI build with the Stable Cadence changes.
Suggested Solution
Create
feature/stable-cadence branches
in downstream dependencies:flow-go
flow-go-sdk
flow-emulator
flow-nft
nft-storefront
The text was updated successfully, but these errors were encountered: