Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Downstream deps for stable-cadence branch #2084

Closed
5 tasks done
j1010001 opened this issue Oct 21, 2022 · 14 comments
Closed
5 tasks done

Update Downstream deps for stable-cadence branch #2084

j1010001 opened this issue Oct 21, 2022 · 14 comments
Assignees
Labels

Comments

@j1010001
Copy link
Member

j1010001 commented Oct 21, 2022

Issue To Be Solved

We would like to have a CLI build with the Stable Cadence changes.

Suggested Solution

Create feature/stable-cadence branches in downstream dependencies:

  • flow-go
  • flow-go-sdk
  • flow-emulator
  • flow-nft
  • nft-storefront
@turbolent
Copy link
Member

turbolent commented Oct 28, 2022

Currently the update of flow-go is blocked by an update of the Flow core contracts to Stable Cadence, tracked in #1820.

Pinged here:

@turbolent
Copy link
Member

Core contracts are updated: onflow/flow-core-contracts#319

Updated flow-go to the updated core contracts and updated the tests in: onflow/flow-go#3498

@turbolent
Copy link
Member

turbolent commented Nov 3, 2022

Next blocker is the NFT standard contract. It uses view as an identifier, but view was made a keyword.
@dreamsmasher will work on making view a soft-keyword to avoid making this a breaking change for existing contracts in #2120. Challenge is still allowing view function expressions (view fun() {...})

@sideninja
Copy link
Contributor

@turbolent
Copy link
Member

Yes, good point. I'll tag them

@sideninja
Copy link
Contributor

Yes, good point. I'll tag them

We were using a tag called -sc if I remember correctly.

@turbolent
Copy link
Member

Tagged, updated the comment above

@sideninja
Copy link
Contributor

Thank you. Should I release a CLI with these versions? By when should a release be ready?

@turbolent
Copy link
Member

Yes, that would be great, thanks! We also need to update the Cadence tools (e.g. test framework, language server). I can take care of this too if you want.

As for timing, there's no rush, we just like to get a preview release out as soon as it's ready, so that developers can start updating their contracts early and give feedback on the changes.

@turbolent
Copy link
Member

turbolent commented Nov 10, 2022

@sideninja Everything is now updated to preview 4 in onflow/flow-cli@master...release/stable-cadence, so it would be nice to get a release for that out

@turbolent
Copy link
Member

turbolent commented Nov 17, 2022

Greg successfully built a CLI binary with preview 4.

I tested it and found issues relating to view functions. #2141 fixes the issues and is merged now.

I'll tag preview 5 and do another round of updates, which will luckily from now on just be version bumps.

@turbolent
Copy link
Member

Tagged and updated everything to preview 5: onflow/flow-cli@master...release/stable-cadence. Ping Gregor to build and publish another CLI release of that branch

@turbolent
Copy link
Member

CLI preview release tagged: https://github.com/onflow/flow-cli/releases/tag/v0.41.3-stable-cadence-5

Going to wait for feedback. If deemed OK, will announce as first preview release for Stable Cadence and close issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants