Feature: EFM Recovery, Protocol HCU (core-contracts) #465
Commits on Jun 20, 2024
-
-
Update to newest Stable Cadence Preview (#371)
* update to view functions for stable cadence * remove unreachable code * update templates to Stable Cadence * update to Stable Cadence preview 4 * update for stable cadence * fix parse error --------- Co-authored-by: Josh Hannan <[email protected]> Co-authored-by: Bastian Müller <[email protected]>
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Apply suggestions from code review
Co-authored-by: Bastian Müller <[email protected]>
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
add updated manifests with new account, FT, and NFT transactions and …
…removed locked token staking txs
-
-
-
Update contract getter methods to use env (#410)
* update import addresses to better format and use env * update deps * update go mod * re-add lockedaccountinfo * update ft and nft dependencies
-
get address replacement working in tests and add event emission restr…
…ictions for FlowToken
-
-
Don't copy dictionary in getEpochMetadata (#413)
* Don't copy dictionary in getEpochMetadata
-
-
-
-
-
-
-
- add epoch recover event and struct - store recovery epoch metadata in storage, emit event in heartbeat - add ClusterQCVoteData struct to FlowClusterQC contract - add recover epoch transaction
-
-
-
-
upgrade changes to be compliant with cadence 1.0
- add service event verification to tests - update test helpers - add node weight sanity check
-
-
-
-
cant use timing config in epoch recover
- target duration and end time must be provided in governance transaction
-
-
-
Update contracts/epochs/FlowEpoch.cdc
Co-authored-by: Alexander Hentschel <[email protected]>
-
Update contracts/epochs/FlowEpoch.cdc
Co-authored-by: Alexander Hentschel <[email protected]>
-
-
Apply suggestions from code review
Co-authored-by: Jordan Schalm <[email protected]> Co-authored-by: Bastian Müller <[email protected]>
3 people committedJun 20, 2024 -
-
-
-
-
-
-
- dont generate a new random source when overwriting the epoch metadata
- generate random source in contract - update qcVoterData to match protocol struct - fix tests
-
-
-
Add entitlement for locked account creator (#423)
* update deps, add entitlement for locked account creator * make ci
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Commits on Jun 22, 2024
Commits on Jul 10, 2024
Commits on Jul 22, 2024
-
Update contracts/epochs/FlowClusterQC.cdc
Co-authored-by: Jordan Schalm <[email protected]>
-
Apply suggestions from code review
Co-authored-by: Jordan Schalm <[email protected]>
Commits on Jul 25, 2024
-
Sync
feature/efm-recoverywithmaster(#437)* Remove feature branch * Add a new script that checks if payer has balance to pay for tx (#435) * Add a new script that checks if payer has balance to pay for tx * Rewrite check_if_payer_has_sufficient_balance to return struct * Update contract to cadence 1 * create custom minted account * payer executes tx and pays for it * fix tx signers * refactor test --------- Co-authored-by: Chase Fleming <[email protected]> Co-authored-by: Illia <[email protected]>
3 people authoredJul 25, 2024 -
Commits on Jul 28, 2024
Commits on Jul 29, 2024
-
-
-
-
-
Update contracts/epochs/FlowEpoch.cdc
Co-authored-by: Jordan Schalm <[email protected]>
-
Update contracts/epochs/FlowEpoch.cdc
Co-authored-by: Jordan Schalm <[email protected]>
-
-
-
Merge branch 'khalil/5639-epoch-recovery-transaction' of github.com:o…
…nflow/flow-core-contracts into khalil/5639-epoch-recovery-transaction
-
-
Merge pull request #420 from onflow/khalil/5639-epoch-recovery-transa…
…ction EpochRecover service event and transaction
Commits on Jul 30, 2024
-
-
Merge pull request #438 from onflow/revert-420-khalil/5639-epoch-reco…
…very-transaction Revert "EpochRecover service event and transaction"
Commits on Sep 13, 2024
Commits on Oct 15, 2024
-
Add node ID to index mapping to DKG data model (#441)
* define ResultSubmission struct * annotate required changes * setup test framework * add preliminary new fields to EpochCommit * add submission tracker sketch * ResultSubmission tests * ResultSubmission docs * addSubmission method * add tx todos * add init test, validation on ResultSubmission init * test comments * basic SubmissionTracker tests * update other contract methods to use SubmissionTracker * add dummy values for EpochCommit event * add docs * add exceedsThreshold test * update FlowEpoch to compile * update transactions * improve representation for "empty submissions" * add test for empty submission * test empty submission exceeds threshold * fix go test: send submission * wip * remove ' * incredibly, the tests are passing * note where tests still need updating * consistent terminology: empty submission * resolve some todos - make funs view - improve docs - remove commented-out code * fix empty submission dkg tests * fix epoch tests * rename publish admin script was called "publish participant" but was actually publishing admin * store as much as possible in EpochMetadata * build static files * make more functions view * fix test * rename isValidNilSubmission since it is specifically enforcing the named Invariant (1), and checking both empty and non-empty submissions. * update error messages * go generate * Apply suggestions from code review Co-authored-by: Tarak Ben Youssef <[email protected]> Co-authored-by: Joshua Hannan <[email protected]> * 2nd pass over error messages * fix empty whiteboard message test * improve post whiteboard message test * rm dupe test * address remaining todos in tests * add preconditions for dkg enabled * fix message, generate * add documentation for test helper functions --------- Co-authored-by: Tarak Ben Youssef <[email protected]> Co-authored-by: Joshua Hannan <[email protected]>
3 people authoredOct 15, 2024 -
Commits on Oct 25, 2024
-
EFM Recovery Service Event and Transaction (#440)
* efm recovery transaction * use provided recovery epoch counter as the source of truth * add proper line indentation * update assets * define ResultSubmission struct * annotate required changes * setup test framework * add preliminary new fields to EpochCommit * add submission tracker sketch * Apply suggestions from code review Co-authored-by: Alexander Hentschel <[email protected]> Co-authored-by: Jordan Schalm <[email protected]> * Apply suggestions from code review Co-authored-by: Jordan Schalm <[email protected]> Co-authored-by: Alexander Hentschel <[email protected]> * adjust recover transaction logic * move recoverEpochPreChecks call to emitEpochRecoverEvent * fix broken sentence * add comment describing unsafeAllowOverwrite * use previous syntax for randomSource generation * replace usage of numViewsInStakingAuction and numViewsInDKGPhase - replace numViewsInStakingAuction with stakingEndView - startView - don't accept numViewsInDKGPhase as a parameter read it from configurable epoch metadata * add godoc for convertClusterQcsCdc * add additional test cases * ResultSubmission tests * ResultSubmission docs * addSubmission method * add tx todos * add init test, validation on ResultSubmission init * test comments * basic SubmissionTracker tests * update other contract methods to use SubmissionTracker * add dummy values for EpochCommit event * add docs * add exceedsThreshold test * update FlowEpoch to compile * update transactions * improve representation for "empty submissions" * add test for empty submission * test empty submission exceeds threshold * fix go test: send submission * wip * remove ' * incredibly, the tests are passing * note where tests still need updating * consistent terminology: empty submission * resolve some todos - make funs view - improve docs - remove commented-out code * fix empty submission dkg tests * fix epoch tests * rename publish admin script was called "publish participant" but was actually publishing admin * store as much as possible in EpochMetadata * build static files * make more functions view * fix test * add dkgIdMapping * rename isValidNilSubmission since it is specifically enforcing the named Invariant (1), and checking both empty and non-empty submissions. * Updated epoch recovery tx to accept dkg group key as well as emitting correct EpochRecover service event * update error messages * go generate * Apply suggestions from code review Co-authored-by: Tarak Ben Youssef <[email protected]> Co-authored-by: Joshua Hannan <[email protected]> * 2nd pass over error messages * fix empty whiteboard message test * improve post whiteboard message test * rm dupe test * address remaining todos in tests * fix whitespace * Apply suggestions from code review * Update contracts/epochs/FlowDKG.cdc * random source generatation doc/postconditions * recovery function docs * recoverCurrentEpoch precondition * recovery methods internal documentation * add todos * ClusterQCVoteData docs * recover_epoch tx comments * remove duplicated LN vote tag * add todos * make generate * tweak godocs * fixing and annotating tests * all existing epoch recovery tests passing * refactor happy path validation check test * rm duplicate tests * refactor overwrite validation tests * clean up verifyEpochTotalRewardsPaid * fix extra / in comments * refactor success efm recovery tests * rename and document rewards test case * Apply suggestions from code review Co-authored-by: Joshua Hannan <[email protected]> * use stopEpochComponents remove dupe code fragment * comments * validate epoch counter and phase in tests * recoverCurrentEpoch: always start in stakign phase * make generate * totalRewards todos * pass over remaining todos * make generate * update test --------- Co-authored-by: Jordan Schalm <[email protected]> Co-authored-by: Alexander Hentschel <[email protected]> Co-authored-by: Yurii Oleksyshyn <[email protected]> Co-authored-by: Tarak Ben Youssef <[email protected]> Co-authored-by: Joshua Hannan <[email protected]>
6 people authoredOct 25, 2024
Commits on Oct 28, 2024
Commits on Oct 29, 2024
-
Add
ProtocolStateVersionUpgradeservice event (#464)* add service event definition and doc * move service event to version beacon * add heartbeat/admin process for proto state version accepting broken assets.go, will regenerate after cherry-pick is complete * add smoketest for setting protostate version broken assets.go * Apply suggestions from code review * generate broken assets.go * update contract for cadence1 * update admin tx for cadence 1 * generate * emit service event in governance transaction Previously service events could only be emitted in the system chunk. With onflow/flow-go#5828, we can directly emit them in governance transactions. * re-generate assets * fix field reflection * add context for where validation occurs and multiple emissions * make generate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.