Introduce toConstantSized to VariableSizedArray type
#3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdrag00nv2
requested review from
turbolent,
SupunS and
dsainati1
as code owners
darkdrag00nv2
changed the title
VariableSizedArray typetoConstantSized to VariableSizedArray type
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3028 +/- ##
==========================================
+ Coverage 80.37% 80.38% +0.01%
==========================================
Files 364 364
Lines 85173 85308 +135
==========================================
+ Hits 68456 68578 +122
- Misses 14275 14283 +8
- Partials 2442 2447 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@onflow/cadence could you please have a look? it would be great to get this into the next release, it will make using the EVM API much easier |
dsainati1
approved these changes
Jan 18, 2024
SupunS
reviewed
Jan 19, 2024
Co-authored-by: Bastian Müller <[email protected]>
Co-authored-by: Bastian Müller <[email protected]>
Co-authored-by: Supun Setunga <[email protected]>
darkdrag00nv2
force-pushed
the
2530-var-const-array
branch
from
8b66a4b
to
a38010d
Compare
|
Had to force push after resolving merge conflicts. |
SupunS
approved these changes
Jan 19, 2024
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2530
Description
Introduce
toConstantSizedfunction toVariableSizedArraytype. This function will return a constant-sized array whose contents are copies of the original variable-sized array.Since copy of values are involved, this is not available if the inner type of the variable-sized array is a resource.
masterbranchFiles changedin the Github PR explorer