Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize format for EVM txs & data #124

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Mar 4, 2024

Closes: #123

Description

Update Cadence scripts & transactions to accept EVM tx & data as hex-encoded strings instead of Cadence byte arrays. This is far more effiecient with the current JSON-CDC encoder.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Update Cadence scripts & transactions to accept EVM tx & data
as hex-encoded strings instead of Cadence byte arrays. This is
far more effiecient with the current JSON-CDC encoder.
@m-Peter m-Peter added this to the Flow-EVM-M2 milestone Mar 4, 2024
@m-Peter m-Peter self-assigned this Mar 4, 2024
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

services/requester/cadence/call.cdc Outdated Show resolved Hide resolved
integration/e2e_test.go Outdated Show resolved Hide resolved
@m-Peter m-Peter requested a review from sideninja March 4, 2024 17:19
Copy link
Contributor

@sideninja sideninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@sideninja sideninja merged commit 4a3061b into onflow:main Mar 4, 2024
1 check passed
@m-Peter m-Peter deleted the optimize-evm-tx-format branch March 4, 2024 17:30
@turbolent
Copy link
Member

Very nice indeed! 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Transactions should be optimized
3 participants