-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container static types #1125
Conversation
…adence into supun/dictionary-static-type
Return a dedicated error when decoding fails due to an unsupported CBOR tag
… into supun/container-static-types
…/container-static-types-sync
Sync `feature/container-static-types` branch with master
…nflow/cadence into supun/infer-static-type-2
Infer static-type from imported array/dictionary values
…nflow/cadence into supun/container-static-types
Add container mutation check for arrays and dictionaries
…/container-static-types
Codecov Report
@@ Coverage Diff @@
## master #1125 +/- ##
==========================================
- Coverage 75.51% 73.53% -1.98%
==========================================
Files 271 272 +1
Lines 33404 34458 +1054
==========================================
+ Hits 25226 25340 +114
- Misses 7037 7957 +920
- Partials 1141 1161 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are two, similar, TODOs that I think we should resolve before merging.
Other than that, I think we already reviewed all the PRs individually, so don't need a full re-review of it all, and a quick look over it also looks good.
Can't wait to ⛵ this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Closes #870
Description
Add static type information to containers (arrays and dictionaries)
master
branchFiles changed
in the Github PR explorer