Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add encoder/decoder v5 #1039

Merged
merged 4 commits into from
Jun 30, 2021
Merged

Add encoder/decoder v5 #1039

merged 4 commits into from
Jun 30, 2021

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Jun 30, 2021

Work towards #870

Description

Add a new encoder/decoder v5, with no functionality change.

  • Backup the current encoder/decoder as v4
  • Duplicate the same encoder/decoder as v5
  • Update the lazy decoding functions to use the correct decoder based on the version.
  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS mentioned this pull request Jun 30, 2021
Closed
23 tasks
@SupunS SupunS marked this pull request as ready for review June 30, 2021 05:23
@SupunS SupunS requested a review from turbolent as a code owner June 30, 2021 05:23
@SupunS SupunS mentioned this pull request Jun 30, 2021
Merged
6 tasks
@SupunS SupunS self-assigned this Jun 30, 2021
Base automatically changed from bastian/array-static-type to feature/container-static-types June 30, 2021 15:44
turbolent
turbolent approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@turbolent turbolent merged commit 0afd878 into feature/container-static-types Jun 30, 2021
@turbolent turbolent deleted the supun/encoder-v5 branch June 30, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

Assignees

@SupunS SupunS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SupunS @turbolent