Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexport SlabID fields to prevent misuse #323

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Unexport SlabID fields to prevent misuse #323

merged 5 commits into from
Jul 6, 2023

Commits on Jul 6, 2023

  1. Unexport SlabID fields

    @fxamacker
    fxamacker committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    33b8013 View commit details
    Browse the repository at this point in the history

  2. Refactor creating new StorableSlab 

    Currently, in order to create StorableSlab, user needs to:
- generate SlabID from storage
- create new StorableSlab
- store created StorableSlab in storage

This commit unexports StorableSlab fields and adds NewStorableSlab().
With this change, user can simply call NewStorableSlab().
    @fxamacker
    fxamacker committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    0c5a9e0 View commit details
    Browse the repository at this point in the history

  3. Rename ID to ValueID 

    ValueID identifies atree Array and OrderedMap while SlabID identifies
slab in storage.  SlabID should only be used to retrieve, store, and
remove slab in storage.
    @fxamacker
    fxamacker committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    3fa18fe View commit details
    Browse the repository at this point in the history

  4. Merge pull request #325 from onflow/fxamacker/rename-id-to-valueid 

    Rename ID to ValueID
    @fxamacker
    fxamacker authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    37f2201 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #324 from onflow/fxamacker/refactor-new-storableslab 

    Refactor creating new StorableSlab
    @fxamacker
    fxamacker authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    5224515 View commit details
    Browse the repository at this point in the history