Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ID to ValueID #325

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Rename ID to ValueID #325

merged 1 commit into from
Jul 6, 2023

Conversation

fxamacker
Copy link
Member

Updates #296 #292 onflow/flow-go#1744
Updates PR #321 and more context at #321 (comment)

Description

ValueID identifies atree Array and OrderedMap while SlabID identifies slab in storage. SlabID should only be used to retrieve, store, and remove slab in storage.

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@fxamacker
Rename ID to ValueID
3fa18fe 
ValueID identifies atree Array and OrderedMap while SlabID identifies
slab in storage.  SlabID should only be used to retrieve, store, and
remove slab in storage.
@fxamacker fxamacker added improvement breaking change changes to API that can break programs using Atree's API labels Jul 6, 2023
@fxamacker fxamacker self-assigned this Jul 6, 2023
turbolent
turbolent approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@fxamacker fxamacker merged commit 37f2201 into fxamacker/refactor-new-storableslab Jul 6, 2023
@fxamacker fxamacker mentioned this pull request Jul 7, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@ramtinms ramtinms Awaiting requested review from ramtinms

Assignees

@fxamacker fxamacker

Labels
breaking change changes to API that can break programs using Atree's API improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fxamacker @turbolent