-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django 2+ #4454
Merged
gannetson
merged 20 commits into
onepercentclub:upgrade/django
from
jayvdb:2021-01-dj3-phase3
Feb 10, 2021
Merged
Django 2+ #4454
gannetson
merged 20 commits into
onepercentclub:upgrade/django
from
jayvdb:2021-01-dj3-phase3
Feb 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django 2+ incorporated django-subquery.
On Django 2+, the import of FakeTenant during startup causes cyclic importation. It is only needed during invocation of set_tenant.
It was removed in recent releases of djangorestframework-jsonapi
rest_framework.authtoken.models.Token may not be registered by default, in which case it doesnt need to be unregistered.
drf-jwt is the maintained fork of djangorestframework-jwt and it has slightly rearranged a few names.
django-nested-inline is currently installed as an indirect dependency, but it is also directly imported so it should be directly listed.
There are multiple package providing package magic, and they differ slightly in how they are implemented. Distros typically provide a different python package which does not support `mime` arg.
DocType was replaced with Document as top level import. django-es/django-elasticsearch-dsl#185
Recent django-polymorphic does not require explicit admins, and this has been deprecated and removed in latest versions.
InlineModelAdmin method has_user_permission has arg obj.
On Django 2+, the namespace arg is not allowed with django.contrib.auth.urls.
Not available on Django 3
Wonderful. I'll work on the next batch of commits for #4313 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simpler part of the commit series described at #4313