Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 2+ #4454

Merged
merged 20 commits into from
Feb 10, 2021
Merged

Django 2+ #4454

merged 20 commits into from
Feb 10, 2021

Conversation

jayvdb
Copy link

@jayvdb jayvdb commented Jan 1, 2021

The simpler part of the commit series described at #4313

jayvdb added 20 commits January 1, 2021 10:05
Django 2+ incorporated django-subquery.
On Django 2+, the import of FakeTenant during startup
causes cyclic importation.
It is only needed during invocation of set_tenant.
It was removed in recent releases of djangorestframework-jsonapi
rest_framework.authtoken.models.Token may not be registered
by default, in which case it doesnt need to be unregistered.
drf-jwt is the maintained fork of djangorestframework-jwt
and it has slightly rearranged a few names.
django-nested-inline is currently installed as an
indirect dependency, but it is also directly imported
so it should be directly listed.
There are multiple package providing package magic,
and they differ slightly in how they are implemented.
Distros typically provide a different python package
which does not support `mime` arg.
DocType was replaced with Document as top level import.
django-es/django-elasticsearch-dsl#185
Recent django-polymorphic does not require explicit admins,
and this has been deprecated and removed in latest versions.
InlineModelAdmin method has_user_permission has arg obj.
On Django 2+, the namespace arg is not allowed
with django.contrib.auth.urls.
Not available on Django 3
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 90.908% when pulling 30df610 on jayvdb:2021-01-dj3-phase3 into 9728466 on onepercentclub:master.

@gannetson gannetson changed the base branch from master to upgrade/django February 10, 2021 13:43
@gannetson gannetson merged commit c35fe3e into onepercentclub:upgrade/django Feb 10, 2021
@jayvdb
Copy link
Author

jayvdb commented Feb 10, 2021

Wonderful. I'll work on the next batch of commits for #4313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants